Page MenuHomePhabricator
Differential D6786

[web] factor out app container position info logic out of tooltip utils
ClosedPublic
Actions

Authored by ginsu on Feb 20 2023, 1:24 PM.
Tags
None
Referenced Files
F3524817: D6786.diff
Mon, Dec 23, 2:45 PM
Unknown Object (File)
Thu, Dec 19, 5:31 PM
Unknown Object (File)
Tue, Dec 3, 1:19 PM
Unknown Object (File)
Oct 28 2024, 11:54 PM
Unknown Object (File)
Oct 28 2024, 11:54 PM
Unknown Object (File)
Oct 28 2024, 11:54 PM
Unknown Object (File)
Oct 28 2024, 11:54 PM
Unknown Object (File)
Oct 28 2024, 11:51 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
tomek
rohan
Commits
rCOMM192fdb2d72a7: [web] factor out app container position info logic out of tooltip utils
Summary

factor out app container position info logic into a function in a seperate window utils file.

Linear Task: ENG-2849

Test Plan

flow and no regressisions in the tooltip positioning

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Feb 20 2023, 1:24 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 20 2023, 1:24 PM
ginsu edited the summary of this revision. (Show Details)Feb 20 2023, 1:30 PM
ginsu added reviewers: atul, tomek, rohan.
ginsu added a parent revision: D6632: [web] introduce the getEmojiKeyboardPosition function.
ginsu mentioned this in D6632: [web] introduce the getEmojiKeyboardPosition function.Feb 20 2023, 1:33 PM
Harbormaster completed remote builds in B16636: Diff 22747.Feb 20 2023, 1:40 PM
ginsu requested review of this revision.Feb 20 2023, 1:40 PM
ginsu edited the summary of this revision. (Show Details)Feb 20 2023, 1:41 PM
ginsu removed a parent revision: D6632: [web] introduce the getEmojiKeyboardPosition function.
ginsu added a child revision: D6632: [web] introduce the getEmojiKeyboardPosition function.
tomek accepted this revision.Feb 21 2023, 1:00 AM

It is a good practice to be more explicit in the test plan. Saying that there are no regression doesn't allow the reviewer to verify if all the important cases were covered.

This revision is now accepted and ready to land.Feb 21 2023, 1:00 AM
ginsu added a comment.Feb 21 2023, 7:36 AM

It is a good practice to be more explicit in the test plan. Saying that there are no regression doesn't allow the reviewer to verify if all the important cases were covered.

Gotcha in the future I will be more explicit about showing that there are no regressions instead of just saying it

ginsu updated this revision to Diff 22931.Feb 22 2023, 7:47 AM

rebase before landing

Harbormaster completed remote builds in B16770: Diff 22931.Feb 22 2023, 8:04 AM
Closed by commit rCOMM192fdb2d72a7: [web] factor out app container position info logic out of tooltip utils (authored by ginsu). · Explain WhyFeb 22 2023, 12:55 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM192fdb2d72a7: [web] factor out app container position info logic out of tooltip utils.

Revision Contents
Changeset List

PathSize
web/
utils/
15 lines
22 lines

Diff 22931

View Options

web/utils/tooltip-utils.js

Loading...
View Options

web/utils/window-utils.js

Loading...