Paths

Table of Contentst

Differential D6788

[Identity] Add deleteUser RPC to proto files
ClosedPublic
Actions

Authored by • jon on Feb 20 2023, 1:34 PM.

Tags

None

Referenced Files

	F2098263: D6788.id22756.diff
	Mon, Jun 24, 2:08 PM

	Unknown Object (File)
	Sun, Jun 23, 12:08 PM

	Unknown Object (File)
	Sat, Jun 22, 11:51 AM

	Unknown Object (File)
	Fri, Jun 21, 7:16 AM

	Unknown Object (File)
	Fri, Jun 21, 3:58 AM

	Unknown Object (File)
	Thu, Jun 20, 10:26 AM

	Unknown Object (File)
	Sun, Jun 16, 12:24 PM

	Unknown Object (File)
	Sun, Jun 16, 9:06 AM

Subscribers

Details

Reviewers

varun
• max
bartek

Commits

rCOMMde8151a7c3c0: [Identity] Add deleteUser RPC to proto files

Summary

Add deleteUser logic to identity service.

Depends on D6787

Part of https://linear.app/comm/issue/ENG-2764

Test Plan

cargo build

Gets end-to-end tested in a later diff

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Feb 20 2023, 1:34 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 20 2023, 1:34 PM

• jon added a child revision: D6789: [Keyserver] Move shared identity client resources to lib.rs.Feb 20 2023, 1:41 PM

Harbormaster completed remote builds in B16640: Diff 22751.Feb 20 2023, 1:49 PM

• jon requested review of this revision.Feb 20 2023, 1:49 PM

Add grpc implementation as it's not that much code

Harbormaster completed remote builds in B16645: Diff 22756.Feb 20 2023, 2:14 PM

• jon added inline comments.Feb 20 2023, 2:26 PM

services/identity/src/database.rs
202 ↗	(On Diff #22756)	This might be a bit misleading, whether or not it deleted something, this will still return as successful.

nice! i noticed we never send back the failure enum variant. did you look into best practices for gRPC API design?

This revision is now accepted and ready to land.Feb 21 2023, 9:56 AM

Since the generated bindings require me to send Result<tonic::Response<DeleteUserResponse>, tonic::Status>, I can only send a status. I will just remove the inner result and let the grpc status dictate success.

Remove response enum, as it duplicates GRPC behavior

Harbormaster completed remote builds in B16729: Diff 22884.Feb 21 2023, 11:22 AM

Rebase on master

Harbormaster failed remote builds in B16737: Diff 22894!Feb 21 2023, 1:42 PM

bartek accepted this revision.Feb 21 2023, 1:47 PM

Harbormaster completed remote builds in B16737: Diff 22894.Feb 22 2023, 4:22 PM

Closed by commit rCOMMde8151a7c3c0: [Identity] Add deleteUser RPC to proto files (authored by • jon). · Explain WhyFeb 22 2023, 4:25 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMde8151a7c3c0: [Identity] Add deleteUser RPC to proto files.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

32 lines

19 lines

shared/

protos/

12 lines

Diff 22953

services/identity/src/database.rs

Loading...

services/identity/src/service.rs

Loading...

shared/protos/identity.proto

Loading...