Page MenuHomePhabricator
Differential D6569

[native] Add note about kbInitialProps styles
ClosedPublic
Actions

Authored by bartek on Feb 3 2023, 1:04 PM.
Tags
None
Referenced Files
F3520297: D6569.id22468.diff
Sun, Dec 22, 11:57 PM
F3520051: D6569.id22999.diff
Sun, Dec 22, 11:18 PM
F3518312: D6569.diff
Sun, Dec 22, 7:40 PM
Unknown Object (File)
Oct 30 2024, 5:58 AM
Unknown Object (File)
Oct 30 2024, 5:58 AM
Unknown Object (File)
Oct 30 2024, 5:58 AM
Unknown Object (File)
Oct 30 2024, 5:58 AM
Unknown Object (File)
Oct 30 2024, 5:53 AM
View All 78 Files
Subscribers
atul
tomek

Details

Reviewers
ashoat
Commits
rCOMMa1df47bd1704: [native] Add note about kbInitialProps styles
Summary

Follow up https://phab.comm.dev/D6556?id=21940#inline-43588
This style wasn't used anywhere and I couldn't find anything useful in git history.

Update (see comments below):
It turns out that it is used by react-native-keyboard-input so I added a comment

Depends on D6556

Test Plan

N/A - just added a comment.
Flow and ESLint don't complain.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Feb 3 2023, 1:04 PM
Herald added subscribers: atul, tomek. · View Herald TranscriptFeb 3 2023, 1:04 PM
Harbormaster completed remote builds in B16080: Diff 21967.Feb 3 2023, 1:22 PM
bartek requested review of this revision.Feb 3 2023, 1:22 PM
ashoat requested changes to this revision.Feb 3 2023, 4:01 PM

This is special-case by react-native-keyboard-input: https://github.com/wix/react-native-keyboard-input/blob/acb3a58e96988026f449b48e8b49f49164684d9f/src/KeyboardAccessoryView.js#L115

This revision now requires changes to proceed.Feb 3 2023, 4:01 PM
bartek planned changes to this revision.Feb 4 2023, 9:57 AM
In D6569#196113, @ashoat wrote:

This is special-case by react-native-keyboard-input: https://github.com/wix/react-native-keyboard-input/blob/acb3a58e96988026f449b48e8b49f49164684d9f/src/KeyboardAccessoryView.js#L115

Oh ok, I didn't know that! Maybe it's worth adding a short comment explaining that it's needed by the library and make it less mysterious

ashoat added a comment.Feb 4 2023, 10:17 AM

Yeah, good call... we should add a comment, sorry I didn't do that originally

bartek retitled this revision from [native] Remove unused kbInitialProps styles to [native] Add note about kbInitialProps styles.Feb 13 2023, 8:03 AM
bartek edited the summary of this revision. (Show Details)
bartek edited the test plan for this revision. (Show Details)
bartek updated this revision to Diff 22468.Feb 13 2023, 8:05 AM
  • Reverted style deletions
  • Added a short note explaining where this style is used
bartek added inline comments.Feb 13 2023, 8:06 AM
native/keyboard/keyboard-input-host.react.js
97 ↗(On Diff #22468)

Do we have a way of dealing with URLs longer than 80 chars?

ashoat accepted this revision.Feb 13 2023, 9:23 AM
ashoat added inline comments.
native/keyboard/keyboard-input-host.react.js
97 ↗(On Diff #22468)

Nah this is fine

This revision is now accepted and ready to land.Feb 13 2023, 9:23 AM
Harbormaster completed remote builds in B16431: Diff 22468.Feb 13 2023, 9:32 AM
Closed by commit rCOMMa1df47bd1704: [native] Add note about kbInitialProps styles (authored by bartek). · Explain WhyFeb 23 2023, 6:35 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMa1df47bd1704: [native] Add note about kbInitialProps styles.

Revision Contents
Changeset List

PathSize
native/
keyboard/
2 lines

Diff 22999

View Options

native/keyboard/keyboard-input-host.react.js

Loading...