[native] Allow MediaGallery items to mount pre-selected
ClosedPublic
Actions

Authored by bartek on Feb 1 2023, 8:46 AM.

Details

Reviewers

ashoat
• przemek
inka
ginsu

Commits

rCOMM382baa4e984b: [native] Allow MediaGallery items to mount pre-selected

Summary

For the approach described in https://linear.app/comm/issue/ENG-2411#comment-c4d6a4a4 to work, items can appear in MediaGalleryKeyboard preselected.
I need that MediaGalleryMedia component can be mounted with the pre-selected state already.

I basically copied code that animates the green checkmark from componentDidUpdate to componentDidMount.

Test Plan

Ensured that items that have isQueued = true when mounted have the green checkmark displayed and animated.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Feb 1 2023, 8:46 AM

bartek held this revision as a draft.

Herald added subscribers: atul, tomek. · View Herald TranscriptFeb 1 2023, 8:46 AM

bartek added a child revision: D6495: [native] Add function to open native picker.Feb 1 2023, 8:54 AM

Harbormaster completed remote builds in B15939: Diff 21762.Feb 1 2023, 9:03 AM

bartek published this revision for review.Feb 1 2023, 10:15 AM

ashoat requested changes to this revision.Feb 1 2023, 11:03 AM

ashoat added inline comments.

native/media/media-gallery-media.react.js
56 ↗	(On Diff #21762)	Instead of animating these on mount, I think we should initialize them to the correct value. We can move the initialization of `focusProgress` and `checkProgress` to `constructor`, and pick the values based on `isActive` and `isQueued`. What do you think?