Details
This is how it looks:
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Looks good! I assume you figured out the Android issues?
Please address inline comment before landing
native/media/media-gallery-keyboard.react.js | ||
---|---|---|
611 ↗ | (On Diff #21766) | We typically prefer to avoid custom colors like this – it might not look good in light mode, and it breaks the design system. Can you reach out to the design team (maybe on DES-17, feel free to reopen) to figure out what color in native/themes/colors.js we can use for this? If there's no good option, then it would be good to check what the color should be in light mode and introduce it to native/themes/colors.js |
native/media/media-gallery-keyboard.react.js | ||
---|---|---|
611 ↗ | (On Diff #21766) | I took this value directly from Figma, but I suspect that when I blend it with the background color to get rid of alpha, I'll receive something very close to an existing value in colors.js. |
Unblocking so you can land. Feel free to create a follow-up task regarding the color, but ideally we can swap it with something in the design system