Details

Reviewers

tomek
kamil
ashoat

Commits

rCOMM94577d82ecc4: [native] Added terminate() implementation in JS and CommCoreModule

Summary

Update of CommCoreModuleSchema.js and associated codegen files, implementation of CommCoreModule::terminate

Test Plan

Compiled the binary code.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• kuba created this revision.Feb 22 2023, 2:54 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 22 2023, 2:54 AM

• kuba edited the summary of this revision. (Show Details)Feb 22 2023, 2:55 AM

• kuba edited the test plan for this revision. (Show Details)

• kuba added a reviewer: ashoat.

• kuba edited the test plan for this revision. (Show Details)

Removed TODO which was added accidentally

Harbormaster completed remote builds in B16764: Diff 22925.Feb 22 2023, 3:10 AM

Harbormaster completed remote builds in B16765: Diff 22926.Feb 22 2023, 3:17 AM

• kuba requested review of this revision.Feb 22 2023, 3:17 AM

It looks great, but I think this should be two or three diffs:

Update of CommCoreModuleSchema.js and associated codegen files, and implementation of CommCoreModule::terminate
Replacing react-native-exit-app calls with CommCoreModule calls
Delete of react-native-exit-app (potentially could be combined with 2)

@kuba, have you worked with a diff stack before? This might be a good opportunity to learn!

Resigning so it stays on other reviewers' queues

In D6834#203216, @ashoat wrote:

@kuba, have you worked with a diff stack before? This might be a good opportunity to learn!

I haven't. So I am going to split this into 2/3 diffs.

Splitting into 3 diffs

Removed added unintentionally "TODO"

• kuba retitled this revision from [native] Removed `react-native-exit-app` library to [native] Added terminate() implementation in JS and CommCoreModule.Feb 23 2023, 3:50 AM

• kuba edited the summary of this revision. (Show Details)

• kuba edited the test plan for this revision. (Show Details)

• kuba added a child revision: D6844: [native] Replaced react-native-exit-app calls with CommCoreModule calls.Feb 23 2023, 3:57 AM

Harbormaster completed remote builds in B16805: Diff 22974.Feb 23 2023, 3:58 AM

Harbormaster completed remote builds in B16806: Diff 22975.Feb 23 2023, 4:00 AM

ashoat accepted this revision.Feb 23 2023, 11:33 AM

This revision is now accepted and ready to land.Feb 23 2023, 11:33 AM

Closed by commit rCOMM94577d82ecc4: [native] Added terminate() implementation in JS and CommCoreModule (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyFeb 24 2023, 4:12 AM

This revision was automatically updated to reflect the committed changes.

kosmydel <kukubaczek@gmail.com> added a commit: rCOMM94577d82ecc4: [native] Added terminate() implementation in JS and CommCoreModule.