[identity] add session initialization info to RegisterUser and LoginUser RPCs
ClosedPublic
Actions

Authored by varun on Feb 27 2023, 7:19 PM.

Details

Reviewers

tomek
bartek
• jon

Commits

rCOMM72229cb20a14: [identity] add session initialization info to RegisterUser and LoginUser RPCs

Summary

We need to send session initialization info to the identity service as part of the registration and login workflows so that the service can provide this info to clients trying to establish a new channel of communication subsequently with a given user.

The contents of the session initialization map are described in the .proto file.

Test Plan

Tried to register a new user without session initialization info, failed as expected
Tried to register a new user with session initialization info, succeeded and DDB showed the keys + signature + social proof
Tried to log in an existing user with new session initialization info (i.e. different device), succeeded and DDB showed both sets of info, keyed by the public key

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Feb 27 2023, 7:19 PM

Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 27 2023, 7:19 PM

varun added a parent revision: D6904: [identity] GetSessionInitializationInfo RPC.Feb 27 2023, 7:21 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 27 2023, 7:22 PM

Harbormaster failed remote builds in B16974: Diff 23210!

fix CI

I've left some "todo's" in the native_rust_library part of this diff. CXX doesn't support HashMaps yet, so we probably need to provide each key-value pair individually. Since we're not actually using this code right now, I'm deferring this work. Not creating a linear task immediately since it'll be obvious to address this when we get to it next month

Harbormaster completed remote builds in B16976: Diff 23212.Feb 27 2023, 8:00 PM

varun requested review of this revision.Feb 27 2023, 8:00 PM

clean up imports

Harbormaster completed remote builds in B16980: Diff 23219.Feb 27 2023, 9:52 PM

bartek accepted this revision.Feb 28 2023, 12:27 AM

This revision is now accepted and ready to land.Feb 28 2023, 12:27 AM

the rust is pretty boilerplate, but I'll defer to someone else about intent

Closed by commit rCOMM72229cb20a14: [identity] add session initialization info to RegisterUser and LoginUser RPCs (authored by varun). · Explain WhyFeb 28 2023, 7:23 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM72229cb20a14: [identity] add session initialization info to RegisterUser and LoginUser RPCs.