Page MenuHomePhabricator
Differential D7015

[native] Replace LayoutAnimation for driving fixed Tooltip animation
ClosedPublic
Actions

Authored by ashoat on Mar 8 2023, 1:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 2:20 AM
Unknown Object (File)
Fri, Apr 4, 1:46 PM
Unknown Object (File)
Thu, Apr 3, 8:38 AM
Unknown Object (File)
Thu, Apr 3, 8:38 AM
Unknown Object (File)
Thu, Apr 3, 8:38 AM
Unknown Object (File)
Thu, Apr 3, 8:38 AM
Unknown Object (File)
Sat, Mar 29, 9:30 PM
Unknown Object (File)
Feb 24 2025, 5:07 PM
View All Files
Subscribers
atul
tomek

Details

Reviewers
ginsu
Commits
rCOMM5da7d4f027af: [native] Replace LayoutAnimation for driving fixed Tooltip animation
Summary

Driving this separately via LayoutAnimation looks janky. This diff makes us drive it using the same position that the rest of the animation is driven with.

Depends on D7014

Test Plan

Flow, and testing the reaction popover animation on iOS and Android release builds, including opening the emoji keyboard

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/tooltip-animation
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
tooltip/
23 lines

Diff 23556

View Options

native/tooltip/tooltip.react.js

Show All 27 Lines
import { import {
type ServerServerRequest, type ServerServerRequest,
serverServerRequestValidator, serverServerRequestValidator,
type ClientServerRequest, type ClientServerRequest,
type ClientResponse, type ClientResponse,
type ClientClientResponse, type ClientClientResponse,
} from './request-types.js'; } from './request-types.js';
import type { SessionState, SessionIdentification } from './session-types.js'; import type { SessionState, SessionIdentification } from './session-types.js';
import { type RawThreadInfos } from './thread-types.js'; import type {
RawThreadInfos,
MinimallyEncodedRawThreadInfos,
} from './thread-types.js';
import { import {
type ClientUpdatesResult, type ClientUpdatesResult,
type ClientUpdatesResultWithUserInfos, type ClientUpdatesResultWithUserInfos,
type ServerUpdatesResult, type ServerUpdatesResult,
serverUpdatesResultValidator, serverUpdatesResultValidator,
type ServerUpdatesResultWithUserInfos, type ServerUpdatesResultWithUserInfos,
serverUpdatesResultWithUserInfosValidator, serverUpdatesResultWithUserInfosValidator,
} from './update-types.js'; } from './update-types.js';
▲ Show 20 Lines • Show All 134 Lines • ▼ Show 20 Lines
export const stateSyncPayloadTypes = Object.freeze({ export const stateSyncPayloadTypes = Object.freeze({
FULL: 0, FULL: 0,
INCREMENTAL: 1, INCREMENTAL: 1,
}); });
export const fullStateSyncActionType = 'FULL_STATE_SYNC'; export const fullStateSyncActionType = 'FULL_STATE_SYNC';
export type BaseFullStateSync = { export type BaseFullStateSync = {
+messagesResult: MessagesResponse, +messagesResult: MessagesResponse,
+threadInfos: RawThreadInfos,
+rawEntryInfos: $ReadOnlyArray<RawEntryInfo>, +rawEntryInfos: $ReadOnlyArray<RawEntryInfo>,
+userInfos: $ReadOnlyArray<UserInfo>, +userInfos: $ReadOnlyArray<UserInfo>,
+updatesCurrentAsOf: number, +updatesCurrentAsOf: number,
}; };
const baseFullStateSyncValidator = tShape<BaseFullStateSync>({ const baseFullStateSyncValidator = tShape<BaseFullStateSync>({
messagesResult: messagesResponseValidator, messagesResult: messagesResponseValidator,
threadInfos: t.dict(tID, rawThreadInfoValidator),
rawEntryInfos: t.list(rawEntryInfoValidator), rawEntryInfos: t.list(rawEntryInfoValidator),
userInfos: t.list(userInfoValidator), userInfos: t.list(userInfoValidator),
updatesCurrentAsOf: t.Number, updatesCurrentAsOf: t.Number,
}); });
export type ClientFullStateSync = { export type ClientFullStateSync = $ReadOnly<{
...BaseFullStateSync, ...BaseFullStateSync,
+threadInfos: MinimallyEncodedRawThreadInfos,
+currentUserInfo: CurrentUserInfo, +currentUserInfo: CurrentUserInfo,
}; }>;
export type StateSyncFullActionPayload = { export type StateSyncFullActionPayload = $ReadOnly<{
...ClientFullStateSync, ...ClientFullStateSync,
+calendarQuery: CalendarQuery, +calendarQuery: CalendarQuery,
+keyserverID: string, +keyserverID: string,
}; }>;
export type ClientStateSyncFullSocketPayload = { export type ClientStateSyncFullSocketPayload = $ReadOnly<{
...ClientFullStateSync, ...ClientFullStateSync,
+type: 0, +type: 0,
// Included iff client is using sessionIdentifierTypes.BODY_SESSION_ID // Included iff client is using sessionIdentifierTypes.BODY_SESSION_ID
+sessionID?: string, +sessionID?: string,
}; }>;
export type ServerFullStateSync = { export type ServerFullStateSync = $ReadOnly<{
...BaseFullStateSync, ...BaseFullStateSync,
+threadInfos: RawThreadInfos,
+currentUserInfo: CurrentUserInfo, +currentUserInfo: CurrentUserInfo,
}; }>;
const serverFullStateSyncValidator = tShape<ServerFullStateSync>({ const serverFullStateSyncValidator = tShape<ServerFullStateSync>({
...baseFullStateSyncValidator.meta.props, ...baseFullStateSyncValidator.meta.props,
threadInfos: t.dict(tID, rawThreadInfoValidator),
currentUserInfo: currentUserInfoValidator, currentUserInfo: currentUserInfoValidator,
}); });
export type ServerStateSyncFullSocketPayload = { export type ServerStateSyncFullSocketPayload = {
atulAuthorUnsubmitted
Done
Inline Actions

Get the following when I try making this $ReadOnly:

922a45.png (754×1 px, 374 KB)

atul: Get the following when I try making this `$ReadOnly`: {F1058362}
...ServerFullStateSync, ...ServerFullStateSync,
+type: 0, +type: 0,
// Included iff client is using sessionIdentifierTypes.BODY_SESSION_ID // Included iff client is using sessionIdentifierTypes.BODY_SESSION_ID
+sessionID?: string, +sessionID?: string,
}; };
const serverStateSyncFullSocketPayloadValidator = const serverStateSyncFullSocketPayloadValidator =
tShape<ServerStateSyncFullSocketPayload>({ tShape<ServerStateSyncFullSocketPayload>({
...serverFullStateSyncValidator.meta.props, ...serverFullStateSyncValidator.meta.props,
▲ Show 20 Lines • Show All 328 Lines • Show Last 20 Lines