Page MenuHomePhabricator
Differential D7035

[native] Implement `getSignedIdentityKeysBlob(...)` for `native`
ClosedPublic
Actions

Authored by atul on Mar 10 2023, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 11:35 PM
Unknown Object (File)
Sat, Dec 7, 11:35 PM
Unknown Object (File)
Sat, Dec 7, 11:35 PM
Unknown Object (File)
Fri, Dec 6, 6:03 AM
Unknown Object (File)
Wed, Dec 4, 3:21 AM
Unknown Object (File)
Nov 8 2024, 7:37 AM
Unknown Object (File)
Nov 8 2024, 7:37 AM
Unknown Object (File)
Nov 8 2024, 7:37 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMc6ac8fec2856: [native] Implement `getSignedIdentityKeysBlob(...)` for `native`
Summary

In this diff we implement getSignedIdentityKeysBlob(...) and pass it to nativeGetClientResponsesSelector...) so we can call it from within the function created by getClientResponsesSelector(...) if we need to handle serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB.

Depends on D7034

Test Plan

See if ClientClientResponse for serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB is properly constructed and received by keyserver.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D7035 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 10 2023, 4:57 PM
atul published this revision for review.Mar 10 2023, 4:58 PM
Harbormaster completed remote builds in B17244: Diff 23617.Mar 10 2023, 5:12 PM
atul added a child revision: D7036: [web] Introduce `getSignedIdentityKeysBlobSelector(...)` to generate `getSignedIdentityKeysBlob(...)`.Mar 10 2023, 5:32 PM
ashoat accepted this revision.Mar 11 2023, 5:26 AM
This revision is now accepted and ready to land.Mar 11 2023, 5:26 AM
atul updated this revision to Diff 23627.Mar 11 2023, 1:06 PM

include call to commCoreModule.initializeCryptoAccount(...)

native/selectors/socket-selectors.js
56

I made sure calls to initializeCryptoAccount(...) were "idempotent." We really should be handling this on app launch or something?

atul added a comment.Mar 11 2023, 1:11 PM

See if ClientClientResponse for serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB is properly constructed and received by keyserver.

e1a1b6.png (1×3 px, 701 KB)

Harbormaster completed remote builds in B17250: Diff 23627.Mar 11 2023, 1:22 PM
atul updated this revision to Diff 23628.Mar 11 2023, 1:25 PM

land

Harbormaster completed remote builds in B17251: Diff 23628.Mar 11 2023, 1:40 PM
Closed by commit rCOMMc6ac8fec2856: [native] Implement `getSignedIdentityKeysBlob(...)` for `native` (authored by atul). · Explain WhyMar 11 2023, 2:30 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc6ac8fec2856: [native] Implement `getSignedIdentityKeysBlob(...)` for `native`.

Revision Contents
Changeset List

PathSize
native/
selectors/
13 lines

Diff 23627

View Options

native/selectors/socket-selectors.js

Loading...