Build wasm and js bindings for the client sided opaque
code.
https://linear.app/comm/issue/ENG-3265
Depends on D7022
Details
Details
- Reviewers
varun ashoat tomek bartek - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rCOMMfa13b21baf73: [Comm-opaque2] Add wasm build to client
nix develop cd shared/comm-opaque2 wasm-pack build # pkg directory contains js, ts, and wasm artifacts ls pkg/
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- jonringer/refactor-opaque (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Add @ashoat because addtion of wasm-pack utility, and new usage of wasm_bindgen crate
Comment Actions
This currently produces the outpus:
$ du -hd0 --apparent-size pkg/* 715 pkg/comm_opaque.d.ts 160 pkg/comm_opaque.js 14K pkg/comm_opaque_bg.js 142K pkg/comm_opaque_bg.wasm 1005 pkg/comm_opaque_bg.wasm.d.ts 249 pkg/package.json
| shared/comm-opaque2/Cargo.toml | ||
|---|---|---|
| 11 ↗ | (On Diff #23808) | where does this get used? |
| 22 ↗ | (On Diff #23808) | optimize |
| shared/comm-opaque2/src/client/login.rs | ||
| 32 ↗ | (On Diff #23808) | why do we need the wasm_bindgen attribute on every function? other examples i looked at only had it above the impl block |
| shared/comm-opaque2/src/client/register.rs | ||
| 29 ↗ | (On Diff #23808) | again don't think we need all these decorators |
| shared/comm-opaque2/src/error.rs | ||
| 5 ↗ | (On Diff #23808) | I would say due to Rust's orphan rules |
| shared/comm-opaque2/src/lib.rs | ||
| 54–55 ↗ | (On Diff #23803) | nit: maybe rename login_client to client_login just for consistency |
Comment Actions
Address Feedback
| shared/comm-opaque2/Cargo.toml | ||
|---|---|---|
| 11 ↗ | (On Diff #23808) | rand brings in getrandom. It essentially fails to compile unless you specify this dependency |
| 22 ↗ | (On Diff #23808) | apparently I've been around too many british :/ |
| shared/comm-opaque2/src/client/login.rs | ||
| 32 ↗ | (On Diff #23808) | you're right, we don't. Was just following wasm-opaque. |
| shared/comm-opaque2/src/lib.rs | ||
| 54–55 ↗ | (On Diff #23803) | fair |
| shared/comm-opaque2/src/error.rs | ||
|---|---|---|
| 5 | can not -> cannot | |