This adds a stubbed out version of the identity service
given the current state of the protobuf file.
This is intended to allow for the RPCs be worked in parallel.
Details
Details
cd services/identity cargo run -- server
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/identity/build.rs | ||
|---|---|---|
| 2–11 | I like this one! | |
| services/identity/src/main.rs | ||
| 62–66 | These could be named consistently, especially the svc var could be renamed in this context - maybe call these keyserver_service and client_service - I'm not sure if they're more "services" or "servers" (I'm not good at these hyper/tower/tonic namings) | |
| services/identity/src/main.rs | ||
|---|---|---|
| 62–66 | the server vs service distinction is a bit tricky. Because the Trait you need to create an implementation defines a service, but you need to wrap those bindings you created with a server struct. So they are somewhat ambiguous. .add_service is probably chosen to avoid confusion about Server adding servers vs servcies. | |
Comment Actions
nice! just one nit
also why'd we change the way we're installing Protobuf in Docker?
| services/identity/Dockerfile | ||
|---|---|---|
| 7 ↗ | (On Diff #24004) | must be run |