Page MenuHomePhabricator

Allow while(true) in the JS codebase
ClosedPublic

Authored by ashoat on Mar 24 2023, 12:10 PM.
Tags
None
Referenced Files
F1769963: D7173.id24090.diff
Wed, May 15, 10:45 AM
Unknown Object (File)
Wed, May 15, 8:03 AM
Unknown Object (File)
Sun, May 5, 1:27 AM
Unknown Object (File)
Sun, May 5, 1:26 AM
Unknown Object (File)
Sun, May 5, 12:51 AM
Unknown Object (File)
Mon, Apr 29, 7:08 AM
Unknown Object (File)
Apr 6 2024, 3:09 PM
Unknown Object (File)
Mar 28 2024, 3:03 AM
Subscribers
None

Details

Summary

I find that it's sometimes better for readability for the condition of a loop to be determined by a break call inside the body of the loop. More context here.

Test Plan

I edited a file and added a while (true) { break; } line. Before this diff it causes an ESLint error, but afterwards it didn't

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable