Page MenuHomePhabricator
Differential D7174

[keyserver] Fix account deletion performance
ClosedPublic
Actions

Authored by ashoat on Mar 24 2023, 5:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 2:36 AM
Unknown Object (File)
Wed, Nov 6, 3:40 PM
Unknown Object (File)
Wed, Nov 6, 3:39 PM
Unknown Object (File)
Wed, Nov 6, 3:39 PM
Unknown Object (File)
Tue, Nov 5, 4:38 AM
Unknown Object (File)
Tue, Nov 5, 4:38 AM
Unknown Object (File)
Tue, Nov 5, 4:38 AM
Unknown Object (File)
Tue, Nov 5, 4:38 AM
View All Files
Subscribers
None

Details

Reviewers
atul
tomek
• jon
Commits
rCOMM26c2d2f52e0b: [keyserver] Fix account deletion performance
Summary

Account deletion used to time out. After this it's basically instantaneous. The reports table is pretty huge...

More context here on Linear.

Test Plan

I ran it on prod and it fixed the issue

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/delete
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 24 2023, 5:04 PM
ashoat updated this revision to Diff 24105.Mar 24 2023, 5:15 PM

I analyzed the queries we run on the reports table and found that creating a report runs this query, so I refined this index so it can help there as well. No other queries on reports seemed to do a full scan

ashoat updated this revision to Diff 24106.Mar 24 2023, 5:16 PM

Forgot to update createTables in the last revision

ashoat added a reviewer: • jon.Mar 24 2023, 5:20 PM
ashoat added inline comments.
keyserver/src/cron/cron.js
30 ↗(On Diff #24106)

Not sure why I missed this one in D6334. The context is explained there

keyserver/src/database/migration-config.js
224 ↗(On Diff #24106)

I already created this index on prod to test the fix, before I realized it would be better to have a more specific index. This part of the query should only affect prod

Harbormaster completed remote builds in B17610: Diff 24104.Mar 24 2023, 5:20 PM
Harbormaster completed remote builds in B17611: Diff 24105.Mar 24 2023, 5:31 PM
Harbormaster completed remote builds in B17612: Diff 24106.
ashoat requested review of this revision.Mar 24 2023, 5:31 PM
tomek accepted this revision.Mar 27 2023, 2:10 AM
tomek added inline comments.
keyserver/src/cron/cron.js
30 ↗(On Diff #24106)

This is specific to a location of a keyserver, so we can also consider saying that it's in a keyserver's timezone instead of specifying a timezone explicitly.

This revision is now accepted and ready to land.Mar 27 2023, 2:10 AM
ashoat updated this revision to Diff 24196.Mar 27 2023, 7:06 AM

Clarify that it's in the timezone of the keyserver

This revision was landed with ongoing or failed builds.Mar 27 2023, 7:06 AM
Closed by commit rCOMM26c2d2f52e0b: [keyserver] Fix account deletion performance (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM26c2d2f52e0b: [keyserver] Fix account deletion performance.
Harbormaster completed remote builds in B17675: Diff 24196.Mar 27 2023, 7:21 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
cron/
8 lines
database/
11 lines
4 lines

Diff 24196

View Options

keyserver/src/cron/cron.js

Loading...
View Options

keyserver/src/database/migration-config.js

Loading...
View Options

keyserver/src/database/setup-db.js

Loading...