Paths

Table of Contentst

Differential D7220

[keyserver] Update pinnedCount when a message is pinned and unpinned
ClosedPublic
Actions

Authored by rohan on Mar 28 2023, 8:56 AM.

Tags

None

Referenced Files

	F1690459: D7220.diff
	Wed, May 1, 9:43 PM

	Unknown Object (File)
	Wed, Apr 17, 7:39 PM

	Unknown Object (File)
	Fri, Apr 12, 2:33 AM

	Unknown Object (File)
	Thu, Apr 11, 8:31 AM

	Unknown Object (File)
	Thu, Apr 4, 5:33 AM

	Unknown Object (File)
	Mar 29 2024, 12:29 AM

	Unknown Object (File)
	Mar 23 2024, 4:43 AM

	Unknown Object (File)
	Mar 16 2024, 3:15 AM

View All 77 Files

Subscribers

Details

Reviewers

atul
ginsu
tomek
ashoat

Commits

rCOMM6ce90634cf4a: [keyserver] Update pinnedCount when a message is pinned and unpinned

Summary

Now that pinned_count is stored in the database, we want to trigger an update when a message is pinned or unpinned to reflect the most up to date value of how many pins are in a thread.

Linear: https://linear.app/comm/issue/ENG-3403/update-pinnedcount-when-a-message-is-pinned-and-unpinned

Depends on D7211

Test Plan

Trigger a ‘toggle pin’ when the media gallery is opened (for now)
Display the threadInfo.pinnedCount somewhere visible, for the test I displayed it right by ChatThreadListItem
Open the media gallery (to pin a message) on an admin user, and confirm the other account part of the thread receives the updated pin count
Confirm the permissions by trying to doing the same on the non-admin account and having an invalid_credentials server error in my logs
Validate the same, but for unpinning, where the pinned_count should decrease each time

Message Pin

Message Unpin

Diff Detail

Repository

Branch

pinned_messages

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Mar 28 2023, 8:56 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 28 2023, 8:56 AM

rohan edited the summary of this revision. (Show Details)Mar 28 2023, 8:58 AM

rohan edited the test plan for this revision. (Show Details)

rohan added a parent revision: D7211: [keyserver/lib/native] Store the number of pinned messages in ThreadInfo.

rohan attached a referenced file: F450028: Screen Recording 2023-03-28 at 11.46.46 AM.mov. (Show Details)

rohan attached a referenced file: F450023: Screen Recording 2023-03-28 at 11.32.26 AM.mov. (Show Details)

rohan edited the test plan for this revision. (Show Details)

rohan edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B17747: Diff 24287.Mar 28 2023, 9:13 AM

rohan requested review of this revision.Mar 28 2023, 9:13 AM

Move logic from message-creator to thread-updaters

rohan edited the summary of this revision. (Show Details)Mar 28 2023, 10:25 AM

Harbormaster completed remote builds in B17753: Diff 24295.Mar 28 2023, 10:41 AM

ashoat accepted this revision.Mar 28 2023, 11:21 AM

ashoat added inline comments.

keyserver/src/updaters/thread-updaters.js
894	Nit
899	Nit

This revision is now accepted and ready to land.Mar 28 2023, 11:21 AM

rohan added a child revision: D7237: [keyserver/lib] Optimistically create the toggle pin message.Mar 29 2023, 8:00 AM

Fix formatting

Harbormaster completed remote builds in B17784: Diff 24335.Mar 29 2023, 9:00 AM

Rebase

Harbormaster completed remote builds in B17885: Diff 24500.Mar 31 2023, 4:49 AM

Rebase before landing

Harbormaster completed remote builds in B18153: Diff 24855.Apr 7 2023, 2:59 PM

Rebase before landing

This revision was landed with ongoing or failed builds.Apr 11 2023, 9:00 AM

Closed by commit rCOMM6ce90634cf4a: [keyserver] Update pinnedCount when a message is pinned and unpinned (authored by RohanK6 <rohan.khanderia@gmail.com>). · Explain Why

This revision was automatically updated to reflect the committed changes.

RohanK6 <rohan.khanderia@gmail.com> added a commit: rCOMM6ce90634cf4a: [keyserver] Update pinnedCount when a message is pinned and unpinned.

Harbormaster completed remote builds in B18247: Diff 24990.Apr 11 2023, 9:17 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

updaters/

thread-updaters.js

34 lines

Diff 24295

keyserver/src/updaters/thread-updaters.js

Loading...