[native] Set SQLite DB password to `DEBUG` for `DEBUG` builds
ClosedPublic
Actions

Authored by atul on Mar 29 2023, 1:49 PM.

Details

Reviewers

ashoat
marcin
bartek
rohan

Commits

rCOMM4118e62b12af: [native] Set SQLite DB password to `DEBUG` for `DEBUG` builds

Summary

Interacting with the SQLite DB can be a huge pain since the path and password change on every clean install.

In the past, if you wanted to open a SQLite DB in TablePlus/DataGrip/etc, you needed to add some logging that printed SQLiteQueryExecutor::encryptionKey in addition to the DB PATH. This makes it easier and harcodes the password to DEBUG for DEBUG builds.

Test Plan

Tested iOS debug/release build and observed that DEBUG unlocked the SQLite DB under debug, but NOT under release.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 29 2023, 1:49 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 29 2023, 1:49 PM

atul published this revision for review.Mar 29 2023, 1:50 PM

Harbormaster completed remote builds in B17793: Diff 24347.Mar 29 2023, 2:06 PM

What happens if you deploy a debug build to an iOS device that previously had a release build? It would be able to keep using the previously determined encryptionKey, right? (And vice versa, going from debug to release?)

This revision is now accepted and ready to land.Mar 29 2023, 2:31 PM

What happens if you deploy a debug build to an iOS device that previously had a release build? It would be able to keep using the previously determined encryptionKey, right? (And vice versa, going from debug to release?)

Yeah: