Details

Reviewers

bartek
kamil

Commits

rCOMMc3fac1dd0103: [keyserver] Create a page with invite link

Summary

When a user doesn't have the app installed on iOS, clicking the invite link will open this page. User should use a link to App Store to install the app and click a link again to open the invitation.

The design doesn't use correct Comm title font, images and link icon - these will be added in next diffs.

Depends on D7311

Test Plan

Open the page on simulator and on a physical iPhone and check if links work correctly.

Diff Detail

Repository

rCOMM Comm

Branch

invite2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Apr 5 2023, 5:54 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 5 2023, 5:54 AM

tomek edited the summary of this revision. (Show Details)Apr 5 2023, 5:55 AM

tomek edited the summary of this revision. (Show Details)

Rebase

Harbormaster completed remote builds in B17998: Diff 24656.Apr 5 2023, 6:11 AM

Harbormaster completed remote builds in B18001: Diff 24659.Apr 5 2023, 6:27 AM

tomek requested review of this revision.Apr 5 2023, 6:27 AM

tomek added a child revision: D7314: [keyserver] Use the same font as on web.Apr 5 2023, 9:25 AM

It looks like the design has changed but accepting as it will be updated in next iterations, according to summary

keyserver/src/responders/website-responders.js
467	are you sure we don't need `<!DOCTYPE html>`?

This revision is now accepted and ready to land.Apr 6 2023, 2:25 AM

Use new design

Harbormaster completed remote builds in B18032: Diff 24704.Apr 6 2023, 4:01 AM

Specify doctype

tomek edited the summary of this revision. (Show Details)Apr 6 2023, 4:43 AM

Harbormaster completed remote builds in B18033: Diff 24706.Apr 6 2023, 4:59 AM

tomek requested review of this revision.Apr 6 2023, 6:25 AM

tomek added a child revision: D7330: [keyserver] Use correct font for Comm title.Apr 6 2023, 8:21 AM

Update font weight and size

tomek edited the summary of this revision. (Show Details)Apr 7 2023, 6:35 AM

Harbormaster completed remote builds in B18077: Diff 24777.Apr 7 2023, 6:49 AM

kamil accepted this revision.Apr 11 2023, 1:55 AM

kamil added inline comments.

keyserver/src/responders/website-responders.js
566 ↗	(On Diff #24777)	is it needed?
576 ↗	(On Diff #24777)	I think shorter version is better but up to you

This revision is now accepted and ready to land.Apr 11 2023, 1:55 AM

tomek added inline comments.Apr 11 2023, 3:56 AM

keyserver/src/responders/website-responders.js
566 ↗	(On Diff #24777)	Yes. In our design we would like to display one element at the center of available space and one at the center of one of remaining spaces, (something like ___1_2_) which is quite hard to do. It can be easily achieved by using an approach where an empty element is introduced just to make flex positioning easier (like _X_1_2_).
576 ↗	(On Diff #24777)	Not sure why, but that doesn't work - the element isn't displayed.