[keyserver] Update keyserver ENSCache to source Alchemy key via getCommConfig
ClosedPublic
Actions

Authored by ashoat on Apr 7 2023, 3:32 PM.

Details

Reviewers

atul
varun
• jon

Commits

rCOMM243fe48149b9: [keyserver] Update keyserver ENSCache to source Alchemy key via getCommConfig

Summary

Now that we're able to configure the Alchemy key via getCommConfig, we should use that to load the Alchemy key for the keyserver's ENSCache. This requires an await invocation, which necessitated a slight refactor.

Depends on D7357

Test Plan

Create a keyserver/secrets/alchemy.json file with valid config
Make sure my local keyserver is able to do ENS resolution in notifs

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Apr 7 2023, 3:32 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 7 2023, 3:32 PM

ashoat added a child revision: D7367: [keyserver] Update Docker env var forwarding to reflect getCommConfig naming.Apr 7 2023, 3:36 PM

Harbormaster completed remote builds in B18165: Diff 24869.Apr 7 2023, 3:49 PM

ashoat requested review of this revision.Apr 7 2023, 3:49 PM

atul accepted this revision.Apr 8 2023, 3:46 PM

This revision is now accepted and ready to land.Apr 8 2023, 3:46 PM

Closed by commit rCOMM243fe48149b9: [keyserver] Update keyserver ENSCache to source Alchemy key via getCommConfig (authored by ashoat). · Explain WhyApr 8 2023, 4:55 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM243fe48149b9: [keyserver] Update keyserver ENSCache to source Alchemy key via getCommConfig.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

keyserver.js

4 lines

utils/

ens-cache.js

29 lines

Diff 24869

View Options

keyserver/src/keyserver.js