[keyserver][lib][web] Make it possible to call getCommConfig from Webpack config
ClosedPublic
Actions

Authored by ashoat on Apr 7 2023, 10:40 AM.

Details

Reviewers

atul
varun
• jon

Commits

rCOMMaf5d7c94d41f: [keyserver][lib][web] Make it possible to call getCommConfig from Webpack config

Summary

Linear task: ENG-3229.

We have three configs that we need to be accessible from the Webpack build:

COMM_ALCHEMY_KEY
COMM_WALLETCONNECT_KEY
Coming soon: config for identity service

Currently it's a huge pain to configure these in a dev environment. keyserver configs can be imported via getCommConfig, but it doesn't work in other environments.

This diff makes it possible to call getCommConfig from web.

Depends on D7351

Test Plan

I tested with this patch: https://gist.github.com/Ashoat/487aa5a611e84f1751d7c60d82b8e4f9

I made sure that it printed the contents of commapp_url.json when called from landing and web, in both dev and prod modes.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 7 2023, 10:40 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 7 2023, 10:40 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2023, 10:54 AM

Harbormaster failed remote builds in B18118: Diff 24819!

ashoat added a child revision: D7357: [lib][landing][web] Use getCommConfig to get API keys for Webpack builds.Apr 7 2023, 10:58 AM

Fix Docker build

Most of this diff is plumbing to make it possible for web and landing to access the Babel-transpiled (Flow-stripped) dist file that keyserver is set up to generate

Harbormaster completed remote builds in B18162: Diff 24866.Apr 7 2023, 3:17 PM

ashoat requested review of this revision.Apr 7 2023, 3:17 PM

atul accepted this revision.Apr 7 2023, 3:27 PM

This revision is now accepted and ready to land.Apr 7 2023, 3:27 PM

Closed by commit rCOMMaf5d7c94d41f: [keyserver][lib][web] Make it possible to call getCommConfig from Webpack config (authored by ashoat). · Explain WhyApr 8 2023, 4:55 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMaf5d7c94d41f: [keyserver][lib][web] Make it possible to call getCommConfig from Webpack config.