Page MenuHomePhabricator
Differential D7330

[keyserver] Use correct font for Comm title
ClosedPublic
Actions

Authored by tomek on Apr 6 2023, 8:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 6:39 PM
Unknown Object (File)
Fri, Nov 8, 9:58 AM
Unknown Object (File)
Tue, Nov 5, 2:29 AM
Unknown Object (File)
Tue, Nov 5, 2:29 AM
Unknown Object (File)
Mon, Nov 4, 5:09 AM
Unknown Object (File)
Mon, Nov 4, 3:08 AM
Unknown Object (File)
Fri, Nov 1, 12:09 AM
Unknown Object (File)
Fri, Nov 1, 12:09 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
bartek
kamil
Commits
rCOMM8f3b91a09c19: [keyserver] Use correct font for Comm title
Summary

Get fonts url, link it to the page and use in a header.

invite-font.png (2×1 px, 244 KB)

Depends on D7312

Test Plan

Check if the font is used. Inspect web debugger and check if the fonts file is fetched.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Apr 6 2023, 8:21 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 6 2023, 8:21 AM
tomek edited the summary of this revision. (Show Details)Apr 6 2023, 8:22 AM
Harbormaster completed remote builds in B18052: Diff 24738.Apr 6 2023, 8:38 AM
tomek requested review of this revision.Apr 6 2023, 8:38 AM
ashoat added inline comments.Apr 6 2023, 11:07 AM
keyserver/src/responders/website-responders.js
465 ↗(On Diff #24738)

Personally I would add a return here, so you can reduce the indentation on the code below

tomek added a child revision: D7348: [keyserver] Add background and logo images.Apr 7 2023, 7:22 AM
kamil accepted this revision.Apr 11 2023, 2:04 AM
This revision is now accepted and ready to land.Apr 11 2023, 2:04 AM
tomek updated this revision to Diff 24953.Apr 11 2023, 4:04 AM

Rebase

keyserver/src/responders/website-responders.js
465 ↗(On Diff #24738)

Addressed in the diff D7312 that introduced this if

Harbormaster completed remote builds in B18217: Diff 24953.Apr 11 2023, 4:31 AM
Closed by commit rCOMM8f3b91a09c19: [keyserver] Use correct font for Comm title (authored by tomek). · Explain WhyApr 12 2023, 6:48 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM8f3b91a09c19: [keyserver] Use correct font for Comm title.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
5 lines

Diff 25040

View Options

keyserver/src/responders/website-responders.js

Loading...