Page MenuHomePhabricator
Differential D7350

[keyserver] Add an arrow next to a link
ClosedPublic
Actions

Authored by tomek on Apr 7 2023, 8:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 10:02 AM
Unknown Object (File)
Fri, Nov 8, 10:02 AM
Unknown Object (File)
Fri, Nov 8, 3:36 AM
Unknown Object (File)
Tue, Nov 5, 6:05 AM
Unknown Object (File)
Tue, Nov 5, 4:48 AM
Unknown Object (File)
Tue, Nov 5, 4:48 AM
Unknown Object (File)
Tue, Nov 5, 2:43 AM
Unknown Object (File)
Tue, Nov 5, 2:43 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
bartek
kamil
Commits
rCOMM4aa41c3072a5: [keyserver] Add an arrow next to a link
Summary

Add a svg arrow icon next to Comm landing link. The svg was exported from figma and added as a separate file.

invite-arrow-2.png (2×1 px, 262 KB)

Depends on D7348

Test Plan

Open the page on simulator and physical iPhone and check with the icon is displayed and clicking it or the link opens the landing page.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Apr 7 2023, 8:58 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 7 2023, 8:58 AM
Harbormaster completed remote builds in B18112: Diff 24813.Apr 7 2023, 9:20 AM
tomek requested review of this revision.Apr 7 2023, 9:20 AM
kamil accepted this revision.Apr 11 2023, 2:21 AM

Can you share a screenshot of how it looks?

keyserver/src/responders/website-responders.js
616–630 ↗(On Diff #24813)

wondering if putting this into images/[filename].svg and rendering here using <img> tag will not be cleaner and still quick

This revision is now accepted and ready to land.Apr 11 2023, 2:21 AM
tomek updated this revision to Diff 24954.Apr 11 2023, 4:09 AM

Rebase and update background image

tomek added a comment.Apr 11 2023, 4:15 AM
In D7350#219550, @kamil wrote:

Can you share a screenshot of how it looks?

Sure! Sorry for not doing that initially.

keyserver/src/responders/website-responders.js
616–630 ↗(On Diff #24813)

Makes sense! I'll give it a try, but if there are any issues, I'll keep the current approach.

tomek edited the summary of this revision. (Show Details)Apr 11 2023, 4:15 AM
Harbormaster completed remote builds in B18218: Diff 24954.Apr 11 2023, 4:25 AM
tomek updated this revision to Diff 24956.Apr 11 2023, 4:26 AM

Extract icon to a file

tomek edited the summary of this revision. (Show Details)Apr 11 2023, 4:27 AM
Harbormaster completed remote builds in B18220: Diff 24956.Apr 11 2023, 4:42 AM
Closed by commit rCOMM4aa41c3072a5: [keyserver] Add an arrow next to a link (authored by tomek). · Explain WhyApr 12 2023, 6:48 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM4aa41c3072a5: [keyserver] Add an arrow next to a link.

Revision Contents
Changeset List

PathSize
keyserver/
images/
3 lines
src/
responders/
19 lines

Diff 25041

View Options

keyserver/images/arrow_up_right.svg

Loading...
View Options

keyserver/src/responders/website-responders.js

Loading...