Page MenuHomePhabricator

[keyserver] Add an arrow next to a link
ClosedPublic

Authored by tomek on Apr 7 2023, 8:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 10:02 AM
Unknown Object (File)
Fri, Nov 8, 10:02 AM
Unknown Object (File)
Fri, Nov 8, 3:36 AM
Unknown Object (File)
Tue, Nov 5, 6:05 AM
Unknown Object (File)
Tue, Nov 5, 4:48 AM
Unknown Object (File)
Tue, Nov 5, 4:48 AM
Unknown Object (File)
Tue, Nov 5, 2:43 AM
Unknown Object (File)
Tue, Nov 5, 2:43 AM
Subscribers

Details

Summary

Add a svg arrow icon next to Comm landing link. The svg was exported from figma and added as a separate file.

invite-arrow-2.png (2×1 px, 262 KB)

Depends on D7348

Test Plan

Open the page on simulator and physical iPhone and check with the icon is displayed and clicking it or the link opens the landing page.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Apr 7 2023, 9:20 AM

Can you share a screenshot of how it looks?

keyserver/src/responders/website-responders.js
616–630 ↗(On Diff #24813)

wondering if putting this into images/[filename].svg and rendering here using <img> tag will not be cleaner and still quick

This revision is now accepted and ready to land.Apr 11 2023, 2:21 AM

Rebase and update background image

In D7350#219550, @kamil wrote:

Can you share a screenshot of how it looks?

Sure! Sorry for not doing that initially.

keyserver/src/responders/website-responders.js
616–630 ↗(On Diff #24813)

Makes sense! I'll give it a try, but if there are any issues, I'll keep the current approach.

This revision was automatically updated to reflect the committed changes.