Differential D7392

[Tunnelbroker] Create websocket server
ClosedPublic
Actions

Authored by • jon on Apr 11 2023, 4:26 PM.

Tags

None

Referenced Files

	F3276455: D7392.diff
	Sat, Nov 16, 7:29 AM

	Unknown Object (File)
	Tue, Nov 5, 4:08 AM

	Unknown Object (File)
	Tue, Nov 5, 4:08 AM

	Unknown Object (File)
	Tue, Nov 5, 4:08 AM

	Unknown Object (File)
	Tue, Nov 5, 4:08 AM

	Unknown Object (File)
	Mon, Oct 28, 2:11 PM

	Unknown Object (File)
	Mon, Oct 28, 2:11 PM

	Unknown Object (File)
	Mon, Oct 28, 2:10 PM

Subscribers

Details

Reviewers

varun
bartek
• max
ashoat

Commits

rCOMM6b6fa484ea82: [Tunnelbroker] Create websocket server

Summary

Keyservers and in the future, clients, will need to
open a websocket to connect with tunnelbroker. This adds
the initial websocket server and enables logging in rust code.

Depends on D7391

Test Plan

cd services/tunnelbroker
cargo run # should emit log saying that it's bound to port

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Apr 11 2023, 4:26 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 11 2023, 4:26 PM

Harbormaster completed remote builds in B18261: Diff 25021.Apr 11 2023, 4:44 PM

• jon requested review of this revision.Apr 11 2023, 4:44 PM

• jon added inline comments.Apr 12 2023, 7:33 AM

services/tunnelbroker/src/main.rs
16 ↗	(On Diff #25021)	After a quick search through the code base, couldn't find any instance of clients using a tunnelbroker protobuf client to attempt to contact it, so i replaced it.
services/tunnelbroker/src/websockets/mod.rs
7 ↗	(On Diff #25021)	to be consistent

added @ashoat since this is a new dependency.

New dependency looks good!! 1.2k stars on GitHub, updated in the last month, and MIT-licensed

Resigning to let the other reviewers take a look

• jon added a child revision: D7400: [Tunnelbroker] Add message types for existing protobuf messages.Apr 12 2023, 11:15 AM

varun accepted this revision.Apr 12 2023, 12:07 PM

This revision is now accepted and ready to land.Apr 12 2023, 12:07 PM

Prefix env var with COMM_

Harbormaster completed remote builds in B18280: Diff 25053.Apr 12 2023, 12:34 PM

Closed by commit rCOMM6b6fa484ea82: [Tunnelbroker] Create websocket server (authored by • jon). · Explain WhyApr 12 2023, 12:46 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM6b6fa484ea82: [Tunnelbroker] Create websocket server.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

2 lines

src/

12 lines

websockets/

22 lines

Diff 25053

services/tunnelbroker/Cargo.lock

Loading...

services/tunnelbroker/Cargo.toml

Loading...

services/tunnelbroker/src/main.rs

Loading...

services/tunnelbroker/src/websockets/mod.rs

Loading...