[lib] Introduce new ifJustViewer field in ThreadEntity for PRIVATE threads
ClosedPublic
Actions

Authored by ashoat on Apr 15 2023, 11:24 AM.

Details

Reviewers

tomek
atul

Commits

rCOMMa5ce04f66d57: [lib] Introduce new ifJustViewer field in ThreadEntity for PRIVATE threads

Summary

We currently name new ENS users' PRIVATE threads after their wallet address. In order to instead display their ENS name, we want to make the EntityText framework support some way to render an unnamed PRIVATE thread's name as just their username.

Currently we display such threads as "just you". In this diff, we introduce a new ifJustViewer field to make it possible to show "ashoat.eth" instead.

Test Plan

In combination with the following diff, I tested this by deleting and recreating my ashoat.eth account in my local web environment, and confirming that my new PRIVATE thread was displayed with the name "ashoat.eth"

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Apr 15 2023, 11:24 AM

ashoat added a child revision: D7454: [keyserver] Don't specify name for new PRIVATE threads.

ashoat edited the test plan for this revision. (Show Details)Apr 15 2023, 11:25 AM

ashoat mentioned this in D7455: [keyserver] Migration to reset all PRIVATE thread names.Apr 15 2023, 11:42 AM

Harbormaster completed remote builds in B18383: Diff 25188.Apr 15 2023, 11:42 AM

ashoat requested review of this revision.Apr 15 2023, 11:42 AM

tomek accepted this revision.Apr 17 2023, 4:36 AM

tomek added inline comments.

lib/shared/thread-utils.js
873–876	We can probably avoid this logic by implementing thread type specs - just like for message types. Then we would have a method that has one implementation for PRIVATE and one for other types. Obviously, this refactoring would be a lot more complicated than this, but we can consider it in the future.
lib/utils/entity-text.js
248–249	It isn't intuitive to ignore viewer when viewer username mode is selected.