[CommCoreModule] add table for message store threads
ClosedPublic
Actions

Authored by kamil on Apr 17 2023, 9:54 AM.

Details

Reviewers

tomek
marcin

Commits

rCOMM34c957e249a3: [CommCoreModule] add table for message store threads

Summary

This code introduces new table for threads part of messages store. Skipping messageIDs as it can be computed based on message table.

start_reached will be represented as integer 1 and 0 (but will be sent as string from js code according to the current convention)

last_navigated_to and last_pruned are typed as BIGINT, SQLite`s concept of "type affinity" allows us to use INTEGER here but I believe BIGINT might make it clear to someone reading the code that this can not be stored in int. There are both approaches in the codebase so I chose the one I think is better

I think we will be querying based only on id so an additional index will not be needed.

Test Plan

Tested migration for existing clients:

Tested creating a new database for fresh install:

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Apr 17 2023, 9:54 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 17 2023, 9:54 AM

kamil edited the summary of this revision. (Show Details)Apr 17 2023, 9:57 AM

kamil edited the test plan for this revision. (Show Details)

kamil added a child revision: D7469: [CommCoreModule] implement ops for message store threads.Apr 17 2023, 10:07 AM

Harbormaster completed remote builds in B18413: Diff 25224.Apr 17 2023, 10:12 AM

kamil edited the summary of this revision. (Show Details)Apr 18 2023, 12:57 AM

kamil published this revision for review.Apr 18 2023, 2:50 AM

kamil added inline comments.

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
47	whoops, typo, should be `replaceMessageStoreThreads`, I will fix this shortly

tomek accepted this revision.Apr 20 2023, 4:51 AM

tomek added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1088–1090	Wondering if this can be replaced by a single db operation. If not, should we wrap it with transaction?

This revision is now accepted and ready to land.Apr 20 2023, 4:51 AM

fix typo

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1088–1090	Wondering if this can be replaced by a single db operation. Yeah, didn't find anything suitable for this :/ If not, should we wrap it with transaction? I think the design is that all ops are wrapped in the transaction (see here)