Page MenuHomePhabricator
Differential D7470

[native] enable performing message store threads ops
ClosedPublic
Actions

Authored by kamil on Apr 17 2023, 11:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 20, 7:36 AM
Unknown Object (File)
Thu, Jun 13, 2:06 AM
Unknown Object (File)
Tue, May 28, 9:33 PM
Unknown Object (File)
Tue, May 28, 9:33 PM
Unknown Object (File)
Tue, May 28, 9:33 PM
Unknown Object (File)
Tue, May 28, 9:33 PM
Unknown Object (File)
Tue, May 28, 9:32 PM
Unknown Object (File)
Apr 28 2024, 12:58 PM
View All 34 Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
marcin
Commits
rCOMM677c16c8b891: [native] enable performing message store threads ops
Summary

Introduce converting ops to database ops and delete filtering as message store threads operations are now supported.

Depends on D7469

Test Plan

Use app to check if operations works and updates table properly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Apr 17 2023, 11:03 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 17 2023, 11:03 AM
kamil added a child revision: D7471: [native] migrate message store threads to SQLite.Apr 17 2023, 11:18 AM
Harbormaster completed remote builds in B18415: Diff 25226.Apr 17 2023, 11:22 AM
kamil published this revision for review.Apr 18 2023, 2:55 AM
kamil added inline comments.
lib/utils/message-ops-utils.js
238–240 ↗(On Diff #25226)

probably not needed, I just wanted to make sure that ops will not crash (this will cause database deletion) if one of the values will be missing - wondering what reviewers think

ashoat added inline comments.Apr 18 2023, 5:56 AM
lib/utils/message-ops-utils.js
254 ↗(On Diff #25226)

Can you put the easy cases first, and leave this case to the end, so that the indentation level can be reduced?

tomek accepted this revision.Apr 20 2023, 7:44 AM
This revision is now accepted and ready to land.Apr 20 2023, 7:44 AM
kamil updated this revision to Diff 25498.Apr 21 2023, 2:33 AM

put easy casees first

lib/utils/message-ops-utils.js
254 ↗(On Diff #25226)

sure!

Harbormaster completed remote builds in B18612: Diff 25498.Apr 21 2023, 2:50 AM
Closed by commit rCOMM677c16c8b891: [native] enable performing message store threads ops (authored by kamil). · Explain WhyApr 21 2023, 3:11 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM677c16c8b891: [native] enable performing message store threads ops.

Revision Contents
Changeset List

PathSize
lib/
utils/
57 lines

Diff 25503

View Options

lib/utils/message-ops-utils.js

Loading...