Page MenuHomePhabricator
Differential D7639

[web] fix image avatar image being stretched
ClosedPublic
Actions

Authored by ginsu on Apr 26 2023, 4:30 PM.
Tags
None
Referenced Files
F2189436: D7639.id25794.diff
Thu, Jul 4, 10:45 AM
Unknown Object (File)
Wed, Jul 3, 5:32 PM
Unknown Object (File)
Wed, Jul 3, 12:29 PM
Unknown Object (File)
Wed, Jul 3, 11:08 AM
Unknown Object (File)
Wed, Jul 3, 9:45 AM
Unknown Object (File)
Tue, Jul 2, 6:14 PM
Unknown Object (File)
Mon, Jul 1, 9:13 PM
Unknown Object (File)
Sat, Jun 29, 7:57 AM
View All 44 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMMc045a051665e: [web] fix image avatar image being stretched
Summary

As I was working on enabling avatars on web, I noticed that the image avatars were slightly stretched. This diff fixes this issue

Test Plan

Please see the screenshots below to see the changes I made

Before:

Screenshot 2023-04-26 at 7.20.34 PM.png (236×894 px, 39 KB)

After:

Screenshot 2023-04-26 at 7.20.43 PM.png (232×918 px, 43 KB)

For reference this is what image avatars look like on native which now matches the after photo:

Screenshot 2023-04-26 at 7.21.05 PM.png (1×1 px, 524 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 26 2023, 4:30 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 26 2023, 4:30 PM
ginsu edited the test plan for this revision. (Show Details)Apr 26 2023, 4:39 PM
ginsu added reviewers: atul, ashoat.
ginsu attached a referenced file: F511490: Screenshot 2023-04-26 at 7.21.05 PM.png. (Show Details)
ginsu attached a referenced file: F511489: Screenshot 2023-04-26 at 7.20.43 PM.png. (Show Details)
ginsu attached a referenced file: F511488: Screenshot 2023-04-26 at 7.20.34 PM.png. (Show Details)
ginsu added a child revision: D7640: [web] turn off dummy avatar feature flag.Apr 26 2023, 4:44 PM
Harbormaster completed remote builds in B18826: Diff 25794.Apr 26 2023, 4:48 PM
ginsu requested review of this revision.Apr 26 2023, 4:48 PM
ashoat accepted this revision.Apr 27 2023, 10:15 AM
This revision is now accepted and ready to land.Apr 27 2023, 10:15 AM
ginsu updated this revision to Diff 25878.Apr 27 2023, 11:18 AM

rebase before landing

Harbormaster completed remote builds in B18892: Diff 25878.Apr 27 2023, 11:36 AM
Closed by commit rCOMMc045a051665e: [web] fix image avatar image being stretched (authored by ginsu). · Explain WhyApr 27 2023, 12:33 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMc045a051665e: [web] fix image avatar image being stretched.

Revision Contents
Changeset List

PathSize
web/
components/
4 lines
1 line

Diff 25794

View Options

web/components/avatar.css

Loading...
View Options

web/components/avatar.react.js

Loading...