Page MenuHomePhabricator
Differential D7659

[Tunnelbroker] Remove references to cxx
ClosedPublic
Actions

Authored by • jon on Apr 27 2023, 7:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 10:44 AM
Unknown Object (File)
Wed, Apr 2, 5:23 AM
Unknown Object (File)
Mar 21 2025, 4:23 PM
Unknown Object (File)
Mar 11 2025, 12:48 AM
Unknown Object (File)
Mar 11 2025, 12:45 AM
Unknown Object (File)
Mar 11 2025, 12:44 AM
Unknown Object (File)
Mar 11 2025, 12:42 AM
Unknown Object (File)
Mar 1 2025, 3:28 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMebb0fd5c9a2f: [Tunnelbroker] Remove references to cxx
Summary

We no longer use cxx to create a c++ to rust bridge. Just remove.

Test Plan
cd services/tunnelbroker
cargo run

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
3 lines

Diff 25834

View Options

services/tunnelbroker/Cargo.lock

// @flow // @flow
import Alert from 'react-native/Libraries/Alert/Alert.js'; import Alert from 'react-native/Libraries/Alert/Alert.js';
function exitEditAlert(onDiscard: () => void): void { function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
Alert.alert( Alert.alert(
'Discard changes?', 'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.', 'You have unsaved changes which will be discarded if you navigate away.',
[ [
{ {
text: 'Continue editing', text: 'Continue editing',
style: 'cancel', style: 'cancel',
onPress: onPress,
tomekUnsubmitted
Not Done
Inline Actions
import Alert from 'react-native/Libraries/Alert/Alert.js';
- function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
+ function exitEditAlert(onDiscard: () => void, onContinueEditing: ?() => void): void {
Alert.alert(
'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.',
[
{
text: 'Continue editing',
style: 'cancel',
- onPress: onPress,
+ onPress: onContinueEditing,
},
{
text: 'Discard edit',

Maybe we should be more explicit in naming these

tomek: Maybe we should be more explicit in naming these
}, },
{ {
text: 'Discard edit', text: 'Discard edit',
style: 'destructive', style: 'destructive',
onPress: () => { onPress: onDiscard,
onDiscard();
},
}, },
], ],
); );
} }
export { exitEditAlert }; export { exitEditAlert };
View Options

services/tunnelbroker/Cargo.toml

// @flow // @flow
import Alert from 'react-native/Libraries/Alert/Alert.js'; import Alert from 'react-native/Libraries/Alert/Alert.js';
function exitEditAlert(onDiscard: () => void): void { function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
Alert.alert( Alert.alert(
'Discard changes?', 'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.', 'You have unsaved changes which will be discarded if you navigate away.',
[ [
{ {
text: 'Continue editing', text: 'Continue editing',
style: 'cancel', style: 'cancel',
onPress: onPress,
tomekUnsubmitted
Not Done
Inline Actions
import Alert from 'react-native/Libraries/Alert/Alert.js';
- function exitEditAlert(onDiscard: () => void, onPress: ?() => void): void {
+ function exitEditAlert(onDiscard: () => void, onContinueEditing: ?() => void): void {
Alert.alert(
'Discard changes?',
'You have unsaved changes which will be discarded if you navigate away.',
[
{
text: 'Continue editing',
style: 'cancel',
- onPress: onPress,
+ onPress: onContinueEditing,
},
{
text: 'Discard edit',

Maybe we should be more explicit in naming these

tomek: Maybe we should be more explicit in naming these
}, },
{ {
text: 'Discard edit', text: 'Discard edit',
style: 'destructive', style: 'destructive',
onPress: () => { onPress: onDiscard,
onDiscard();
},
}, },
], ],
); );
} }
export { exitEditAlert }; export { exitEditAlert };