Page MenuHomePhabricator
Differential D7684

[native] move selectFromGalleryAndUpdateThreadAvatar to edit thread avatar provider
ClosedPublic
Actions

Authored by ginsu on Apr 28 2023, 12:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 12:19 PM
Unknown Object (File)
Mon, Nov 4, 12:19 PM
Unknown Object (File)
Sun, Oct 27, 2:36 AM
Unknown Object (File)
Sun, Oct 27, 2:36 AM
Unknown Object (File)
Sun, Oct 27, 2:36 AM
Unknown Object (File)
Sun, Oct 27, 2:36 AM
Unknown Object (File)
Sun, Oct 27, 2:34 AM
Unknown Object (File)
Fri, Oct 25, 7:21 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMMbb875e7f83b4: [native] move selectFromGalleryAndUpdateThreadAvatar to edit thread avatar…
Summary

This diff breaks down D7643. This diff is simply now a move diff with one very minor change and is something I will annotate in the code below

Test Plan

I am able to set a thread image avatar with the expected behavior

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 28 2023, 12:34 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 28 2023, 12:34 PM
ginsu added inline comments.Apr 28 2023, 12:39 PM
native/avatars/edit-thread-avatar-provider.react.js
87 ↗(On Diff #25922)

This was added and is used for the updated customKey below to make sure that the customKey does not exceed 80 char

100 ↗(On Diff #25922)

The threadID was added in the custom key to make sure that updateThreadAvatarLoadingStatus worked as expected

ginsu added reviewers: atul, ashoat.Apr 28 2023, 12:40 PM
ginsu mentioned this in D7643: [native] have upload thread avatar processing/uploading loader only appear for thread being updated.Apr 28 2023, 12:49 PM
Harbormaster completed remote builds in B18924: Diff 25922.Apr 28 2023, 12:51 PM
ginsu requested review of this revision.Apr 28 2023, 12:51 PM
ginsu added a child revision: D7643: [native] have upload thread avatar processing/uploading loader only appear for thread being updated.Apr 28 2023, 1:06 PM
ashoat accepted this revision.Apr 28 2023, 2:01 PM
This revision is now accepted and ready to land.Apr 28 2023, 2:01 PM
ginsu updated this revision to Diff 25942.Apr 30 2023, 9:46 PM

rebase before landing

Harbormaster completed remote builds in B18943: Diff 25942.Apr 30 2023, 10:04 PM
Closed by commit rCOMMbb875e7f83b4: [native] move selectFromGalleryAndUpdateThreadAvatar to edit thread avatar… (authored by ginsu). · Explain WhyApr 30 2023, 10:17 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMbb875e7f83b4: [native] move selectFromGalleryAndUpdateThreadAvatar to edit thread avatar….

Revision Contents
Changeset List

Diff 25942

View Options

native/avatars/avatar-hooks.js

Loading...
View Options

native/avatars/edit-thread-avatar-provider.react.js

Loading...
View Options

native/avatars/edit-thread-avatar.react.js

Loading...