Page MenuHomePhabricator
Differential D7644

[native] move navigate to emoji thread avatar creation function to be within edit thread avatar
ClosedPublic
Actions

Authored by ginsu on Apr 26 2023, 10:07 PM.
Tags
None
Referenced Files
F3571035: D7644.diff
Sat, Dec 28, 7:16 AM
Unknown Object (File)
Sun, Dec 15, 6:04 PM
Unknown Object (File)
Sat, Dec 14, 5:33 PM
Unknown Object (File)
Sat, Dec 14, 5:33 PM
Unknown Object (File)
Sat, Dec 14, 5:33 PM
Unknown Object (File)
Sat, Dec 14, 5:33 PM
Unknown Object (File)
Sat, Dec 14, 5:32 PM
Unknown Object (File)
Sat, Dec 14, 5:25 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMf65bfddfcd95: [native] move navigate to emoji thread avatar creation function to be within…
Summary

Small cleanup diff, I figured it would be better to have this logic within EditThreadAvatar

Depends on D7643

Test Plan

flow still able to navigate to the user emoji avatar creation screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 26 2023, 10:07 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 26 2023, 10:07 PM
ginsu edited the summary of this revision. (Show Details)Apr 26 2023, 10:08 PM
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7643: [native] have upload thread avatar processing/uploading loader only appear for thread being updated.
Harbormaster completed remote builds in B18832: Diff 25800.Apr 26 2023, 10:24 PM
ginsu requested review of this revision.Apr 26 2023, 10:24 PM
ginsu added a child revision: D7645: [native] improve factoring out redundant logic for saving an image thread avatar.Apr 26 2023, 10:41 PM
ashoat accepted this revision.Apr 27 2023, 10:25 AM
This revision is now accepted and ready to land.Apr 27 2023, 10:25 AM
ginsu updated this revision to Diff 25927.Apr 28 2023, 1:09 PM

rebase

Harbormaster completed remote builds in B18928: Diff 25927.Apr 28 2023, 1:27 PM
ginsu updated this revision to Diff 25944.Apr 30 2023, 9:49 PM

rebase before landing

Harbormaster completed remote builds in B18945: Diff 25944.Apr 30 2023, 10:07 PM
Closed by commit rCOMMf65bfddfcd95: [native] move navigate to emoji thread avatar creation function to be within… (authored by ginsu). · Explain WhyApr 30 2023, 10:17 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMf65bfddfcd95: [native] move navigate to emoji thread avatar creation function to be within….

Revision Contents
Changeset List

PathSize
native/
avatars/
21 lines
chat/
settings/
20 lines

Diff 25951

View Options

native/avatars/edit-thread-avatar.react.js

Loading...
View Options

native/chat/settings/thread-settings-avatar.react.js

Loading...