Page MenuHomePhabricator
Differential D7695

[native] register user on native (C++ changes)
ClosedPublic
Actions

Authored by varun on May 1 2023, 7:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 2:50 PM
Unknown Object (File)
Mon, Oct 28, 11:25 AM
Unknown Object (File)
Sat, Oct 19, 9:24 AM
Unknown Object (File)
Sat, Oct 19, 9:24 AM
Unknown Object (File)
Sat, Oct 19, 9:24 AM
Unknown Object (File)
Sat, Oct 19, 9:24 AM
Unknown Object (File)
Sat, Oct 19, 9:24 AM
Unknown Object (File)
Sat, Oct 19, 9:18 AM
View All 91 Files
Subscribers
ashoat
atul

Details

Reviewers
ashoat
Commits
rCOMM552ea82de18b: [native] register user on native (C++ changes)
Summary

add registerUser function to CommCoreModule

Test Plan

successfully registered a new user from js

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.May 1 2023, 7:26 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 1 2023, 7:26 AM
Harbormaster completed remote builds in B18955: Diff 25965.May 1 2023, 7:45 AM
varun requested review of this revision.May 1 2023, 7:45 AM
varun added a parent revision: D7694: [native] register user on native (rust changes).May 1 2023, 7:46 AM
ashoat added a comment.May 1 2023, 8:34 AM

Are any CMake changes necessary here? Or does it work because of a GLOB somewhere?

varun updated this revision to Diff 26025.May 2 2023, 4:49 PM

rename identity -> content

varun added a comment.May 2 2023, 4:51 PM
In D7695#228038, @ashoat wrote:

Are any CMake changes necessary here? Or does it work because of a GLOB somewhere?

we glob the files ("MODULE_ROOT_NATIVE_CODE") so no CMake changes needed

Harbormaster completed remote builds in B19005: Diff 26025.May 2 2023, 5:07 PM
varun added a child revision: D7706: [native] login password user on native (rust changes).May 2 2023, 5:09 PM
ashoat added inline comments.May 3 2023, 6:20 AM
native/cpp/CommonCpp/NativeModules/JSIRust.cpp
6 ↗(On Diff #26025)

You should #include all of the stuff you use, so eg. #include <string> for this

varun updated this revision to Diff 26045.May 3 2023, 1:26 PM

include string

varun edited reviewers, added: ashoat; removed: tomek.May 3 2023, 1:26 PM
ashoat accepted this revision.May 3 2023, 1:29 PM

Seems good to me (assuming it passes CI)

This revision is now accepted and ready to land.May 3 2023, 1:29 PM
Harbormaster completed remote builds in B19018: Diff 26045.May 3 2023, 1:46 PM
Closed by commit rCOMM552ea82de18b: [native] register user on native (C++ changes) (authored by varun). · Explain WhyMay 3 2023, 2:02 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM552ea82de18b: [native] register user on native (C++ changes).

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
14 lines
48 lines
12 lines
25 lines
_generated/
ios/
Comm.xcodeproj/
6 lines
native_rust_library/
src/
2 lines
schema/
12 lines

Diff 26049

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/JSIRust.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/JSIRust.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...