Page MenuHomePhabricator
Differential D7695

[native] register user on native (C++ changes)
ClosedPublic
Actions

Authored by varun on May 1 2023, 7:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 3:37 AM
Unknown Object (File)
Fri, Mar 28, 1:12 PM
Unknown Object (File)
Mon, Mar 24, 7:27 PM
Unknown Object (File)
Mon, Mar 24, 6:36 PM
Unknown Object (File)
Sun, Mar 23, 10:33 PM
Unknown Object (File)
Sat, Mar 22, 8:53 PM
Unknown Object (File)
Sat, Mar 22, 2:39 PM
Unknown Object (File)
Feb 26 2025, 7:18 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
ashoat
Commits
rCOMM552ea82de18b: [native] register user on native (C++ changes)
Summary

add registerUser function to CommCoreModule

Test Plan

successfully registered a new user from js

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.May 1 2023, 7:26 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 1 2023, 7:26 AM
Harbormaster completed remote builds in B18955: Diff 25965.May 1 2023, 7:45 AM
varun requested review of this revision.May 1 2023, 7:45 AM
varun added a parent revision: D7694: [native] register user on native (rust changes).May 1 2023, 7:46 AM
ashoat added a comment.May 1 2023, 8:34 AM

Are any CMake changes necessary here? Or does it work because of a GLOB somewhere?

varun updated this revision to Diff 26025.May 2 2023, 4:49 PM

rename identity -> content

varun added a comment.May 2 2023, 4:51 PM
In D7695#228038, @ashoat wrote:

Are any CMake changes necessary here? Or does it work because of a GLOB somewhere?

we glob the files ("MODULE_ROOT_NATIVE_CODE") so no CMake changes needed

Harbormaster completed remote builds in B19005: Diff 26025.May 2 2023, 5:07 PM
varun added a child revision: D7706: [native] login password user on native (rust changes).May 2 2023, 5:09 PM
ashoat added inline comments.May 3 2023, 6:20 AM
native/cpp/CommonCpp/NativeModules/JSIRust.cpp
6 ↗(On Diff #26025)

You should #include all of the stuff you use, so eg. #include <string> for this

varun updated this revision to Diff 26045.May 3 2023, 1:26 PM

include string

varun edited reviewers, added: ashoat; removed: tomek.May 3 2023, 1:26 PM
ashoat accepted this revision.May 3 2023, 1:29 PM

Seems good to me (assuming it passes CI)

This revision is now accepted and ready to land.May 3 2023, 1:29 PM
Harbormaster completed remote builds in B19018: Diff 26045.May 3 2023, 1:46 PM
Closed by commit rCOMM552ea82de18b: [native] register user on native (C++ changes) (authored by varun). · Explain WhyMay 3 2023, 2:02 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM552ea82de18b: [native] register user on native (C++ changes).

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
14 lines
48 lines
12 lines
25 lines
_generated/
ios/
Comm.xcodeproj/
6 lines
native_rust_library/
src/
2 lines
schema/
12 lines

Diff 26049

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines
export type FFmpegStatistics = { export type FFmpegStatistics = {
// seconds of video being processed per second // seconds of video being processed per second
+speed: number, +speed: number,
// total milliseconds of video processed so far // total milliseconds of video processed so far
+time: number, +time: number,
// total result file size in bytes so far // total result file size in bytes so far
+size: number, +size: number,
+videoQuality: number,
+videoFrameNumber: number,
+videoFps: number,
+bitrate: number,
}; };
export type TranscodeVideoMediaMissionStep = { export type TranscodeVideoMediaMissionStep = {
+step: 'video_ffmpeg_transcode', +step: 'video_ffmpeg_transcode',
+success: boolean, +success: boolean,
+exceptionMessage: ?string, +exceptionMessage: ?string,
+time: number, // ms +time: number, // ms
+returnCode: ?number,
+newPath: ?string, +newPath: ?string,
+stats: ?FFmpegStatistics, +stats: ?FFmpegStatistics,
}; };
export type VideoGenerateThumbnailMediaMissionStep = { export type VideoGenerateThumbnailMediaMissionStep = {
+step: 'video_generate_thumbnail', +step: 'video_generate_thumbnail',
+success: boolean, +success: boolean,
+time: number, // ms +time: number, // ms
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines
export type FFmpegStatistics = { export type FFmpegStatistics = {
// seconds of video being processed per second // seconds of video being processed per second
+speed: number, +speed: number,
// total milliseconds of video processed so far // total milliseconds of video processed so far
+time: number, +time: number,
// total result file size in bytes so far // total result file size in bytes so far
+size: number, +size: number,
+videoQuality: number,
+videoFrameNumber: number,
+videoFps: number,
+bitrate: number,
}; };
export type TranscodeVideoMediaMissionStep = { export type TranscodeVideoMediaMissionStep = {
+step: 'video_ffmpeg_transcode', +step: 'video_ffmpeg_transcode',
+success: boolean, +success: boolean,
+exceptionMessage: ?string, +exceptionMessage: ?string,
+time: number, // ms +time: number, // ms
+returnCode: ?number,
+newPath: ?string, +newPath: ?string,
+stats: ?FFmpegStatistics, +stats: ?FFmpegStatistics,
}; };
export type VideoGenerateThumbnailMediaMissionStep = { export type VideoGenerateThumbnailMediaMissionStep = {
+step: 'video_generate_thumbnail', +step: 'video_generate_thumbnail',
+success: boolean, +success: boolean,
+time: number, // ms +time: number, // ms
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/JSIRust.h

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines
export type FFmpegStatistics = { export type FFmpegStatistics = {
// seconds of video being processed per second // seconds of video being processed per second
+speed: number, +speed: number,
// total milliseconds of video processed so far // total milliseconds of video processed so far
+time: number, +time: number,
// total result file size in bytes so far // total result file size in bytes so far
+size: number, +size: number,
+videoQuality: number,
+videoFrameNumber: number,
+videoFps: number,
+bitrate: number,
}; };
export type TranscodeVideoMediaMissionStep = { export type TranscodeVideoMediaMissionStep = {
+step: 'video_ffmpeg_transcode', +step: 'video_ffmpeg_transcode',
+success: boolean, +success: boolean,
+exceptionMessage: ?string, +exceptionMessage: ?string,
+time: number, // ms +time: number, // ms
+returnCode: ?number,
+newPath: ?string, +newPath: ?string,
+stats: ?FFmpegStatistics, +stats: ?FFmpegStatistics,
}; };
export type VideoGenerateThumbnailMediaMissionStep = { export type VideoGenerateThumbnailMediaMissionStep = {
+step: 'video_generate_thumbnail', +step: 'video_generate_thumbnail',
+success: boolean, +success: boolean,
+time: number, // ms +time: number, // ms
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/JSIRust.cpp

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines
export type FFmpegStatistics = { export type FFmpegStatistics = {
// seconds of video being processed per second // seconds of video being processed per second
+speed: number, +speed: number,
// total milliseconds of video processed so far // total milliseconds of video processed so far
+time: number, +time: number,
// total result file size in bytes so far // total result file size in bytes so far
+size: number, +size: number,
+videoQuality: number,
+videoFrameNumber: number,
+videoFps: number,
+bitrate: number,
}; };
export type TranscodeVideoMediaMissionStep = { export type TranscodeVideoMediaMissionStep = {
+step: 'video_ffmpeg_transcode', +step: 'video_ffmpeg_transcode',
+success: boolean, +success: boolean,
+exceptionMessage: ?string, +exceptionMessage: ?string,
+time: number, // ms +time: number, // ms
+returnCode: ?number,
+newPath: ?string, +newPath: ?string,
+stats: ?FFmpegStatistics, +stats: ?FFmpegStatistics,
}; };
export type VideoGenerateThumbnailMediaMissionStep = { export type VideoGenerateThumbnailMediaMissionStep = {
+step: 'video_generate_thumbnail', +step: 'video_generate_thumbnail',
+success: boolean, +success: boolean,
+time: number, // ms +time: number, // ms
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines
export type FFmpegStatistics = { export type FFmpegStatistics = {
// seconds of video being processed per second // seconds of video being processed per second
+speed: number, +speed: number,
// total milliseconds of video processed so far // total milliseconds of video processed so far
+time: number, +time: number,
// total result file size in bytes so far // total result file size in bytes so far
+size: number, +size: number,
+videoQuality: number,
+videoFrameNumber: number,
+videoFps: number,
+bitrate: number,
}; };
export type TranscodeVideoMediaMissionStep = { export type TranscodeVideoMediaMissionStep = {
+step: 'video_ffmpeg_transcode', +step: 'video_ffmpeg_transcode',
+success: boolean, +success: boolean,
+exceptionMessage: ?string, +exceptionMessage: ?string,
+time: number, // ms +time: number, // ms
+returnCode: ?number,
+newPath: ?string, +newPath: ?string,
+stats: ?FFmpegStatistics, +stats: ?FFmpegStatistics,
}; };
export type VideoGenerateThumbnailMediaMissionStep = { export type VideoGenerateThumbnailMediaMissionStep = {
+step: 'video_generate_thumbnail', +step: 'video_generate_thumbnail',
+success: boolean, +success: boolean,
+time: number, // ms +time: number, // ms
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines
export type FFmpegStatistics = { export type FFmpegStatistics = {
// seconds of video being processed per second // seconds of video being processed per second
+speed: number, +speed: number,
// total milliseconds of video processed so far // total milliseconds of video processed so far
+time: number, +time: number,
// total result file size in bytes so far // total result file size in bytes so far
+size: number, +size: number,
+videoQuality: number,
+videoFrameNumber: number,
+videoFps: number,
+bitrate: number,
}; };
export type TranscodeVideoMediaMissionStep = { export type TranscodeVideoMediaMissionStep = {
+step: 'video_ffmpeg_transcode', +step: 'video_ffmpeg_transcode',
+success: boolean, +success: boolean,
+exceptionMessage: ?string, +exceptionMessage: ?string,
+time: number, // ms +time: number, // ms
+returnCode: ?number,
+newPath: ?string, +newPath: ?string,
+stats: ?FFmpegStatistics, +stats: ?FFmpegStatistics,
}; };
export type VideoGenerateThumbnailMediaMissionStep = { export type VideoGenerateThumbnailMediaMissionStep = {
+step: 'video_generate_thumbnail', +step: 'video_generate_thumbnail',
+success: boolean, +success: boolean,
+time: number, // ms +time: number, // ms
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines
export type FFmpegStatistics = { export type FFmpegStatistics = {
// seconds of video being processed per second // seconds of video being processed per second
+speed: number, +speed: number,
// total milliseconds of video processed so far // total milliseconds of video processed so far
+time: number, +time: number,
// total result file size in bytes so far // total result file size in bytes so far
+size: number, +size: number,
+videoQuality: number,
+videoFrameNumber: number,
+videoFps: number,
+bitrate: number,
}; };
export type TranscodeVideoMediaMissionStep = { export type TranscodeVideoMediaMissionStep = {
+step: 'video_ffmpeg_transcode', +step: 'video_ffmpeg_transcode',
+success: boolean, +success: boolean,
+exceptionMessage: ?string, +exceptionMessage: ?string,
+time: number, // ms +time: number, // ms
+returnCode: ?number,
+newPath: ?string, +newPath: ?string,
+stats: ?FFmpegStatistics, +stats: ?FFmpegStatistics,
}; };
export type VideoGenerateThumbnailMediaMissionStep = { export type VideoGenerateThumbnailMediaMissionStep = {
+step: 'video_generate_thumbnail', +step: 'video_generate_thumbnail',
+success: boolean, +success: boolean,
+time: number, // ms +time: number, // ms
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...