[lib] Fix crash when logged out with sidebar open
ClosedPublic
Actions

Authored by ashoat on May 4 2023, 9:59 AM.

Tags

None

Referenced Files

	F3372525: D7719.id26084.diff
	Tue, Nov 26, 6:50 AM

	F3372395: D7719.id26081.diff
	Tue, Nov 26, 6:26 AM

	Unknown Object (File)
	Mon, Oct 28, 11:25 AM

	Unknown Object (File)
	Oct 19 2024, 9:24 AM

	Unknown Object (File)
	Oct 19 2024, 9:24 AM

	Unknown Object (File)
	Oct 19 2024, 9:24 AM

	Unknown Object (File)
	Oct 19 2024, 9:20 AM

	Unknown Object (File)
	Sep 16 2024, 9:46 PM

View All 66 Files

Subscribers

None

Details

Reviewers

michal
tomek
atul

Commits

rCOMMbded5a4c0cd2: [lib] Fix crash when logged out with sidebar open

Summary

See more details about the crash in ENG-3837. The inline code comment also provides more context on what was happening.

Test Plan

I reproduced the crash described in the Linear issue, and then confirmed it no longer occurs with this change

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 4 2023, 9:59 AM

Harbormaster completed remote builds in B19049: Diff 26081.May 4 2023, 10:17 AM

ashoat requested review of this revision.May 4 2023, 10:17 AM

atul accepted this revision.May 4 2023, 10:22 AM

This revision is now accepted and ready to land.May 4 2023, 10:22 AM

Closed by commit rCOMMbded5a4c0cd2: [lib] Fix crash when logged out with sidebar open (authored by ashoat). · Explain WhyMay 4 2023, 10:23 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMbded5a4c0cd2: [lib] Fix crash when logged out with sidebar open.

Revision Contents
Changeset List

Path

Size

lib/

shared/

mention-utils.js

11 lines

Diff 26084

View Options

lib/shared/mention-utils.js

[lib] Fix crash when logged out with sidebar openClosedPublicActions