Page MenuHomePhabricator

[lib] modify `assertObjectsAreEqual` to return deep differential instead of only one level keys
ClosedPublic

Authored by kamil on May 9 2023, 3:20 AM.
Tags
None
Referenced Files
F3409301: D7754.id27257.diff
Wed, Dec 4, 3:38 PM
F3409245: D7754.id.diff
Wed, Dec 4, 3:23 PM
F3409244: D7754.id27257.diff
Wed, Dec 4, 3:22 PM
F3409241: D7754.id27259.diff
Wed, Dec 4, 3:22 PM
F3409239: D7754.id26276.diff
Wed, Dec 4, 3:21 PM
F3409112: D7754.diff
Wed, Dec 4, 3:01 PM
F3407639: D7754.diff
Wed, Dec 4, 7:07 AM
Unknown Object (File)
Tue, Nov 26, 12:44 AM
Subscribers

Details

Summary

Previously, when keys were the same logging wasn't saying much:

image.png (248×287 px, 62 KB)

Now it shows not only missing keys but diff on each object level:

image.png (299×271 px, 77 KB)

Depends on D7753

Test Plan
  1. Check if this not cause errors on equal objects
  2. Check if this shows detailed information what are the differences between objects

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage