Page MenuHomePhabricator

[lib] modify `assertObjectsAreEqual` to return deep differential instead of only one level keys
ClosedPublic

Authored by kamil on May 9 2023, 3:20 AM.
Tags
None
Referenced Files
F1785295: D7754.id26276.diff
Sat, May 18, 2:33 PM
F1785170: D7754.id27259.diff
Sat, May 18, 1:31 PM
F1782756: D7754.id27257.diff
Sat, May 18, 8:42 AM
Unknown Object (File)
Tue, May 14, 4:03 AM
Unknown Object (File)
Sun, May 5, 11:59 AM
Unknown Object (File)
Fri, Apr 26, 5:11 AM
Unknown Object (File)
Mon, Apr 22, 2:23 PM
Unknown Object (File)
Mon, Apr 22, 2:23 PM
Subscribers

Details

Summary

Previously, when keys were the same logging wasn't saying much:

image.png (248×287 px, 62 KB)

Now it shows not only missing keys but diff on each object level:

image.png (299×271 px, 77 KB)

Depends on D7753

Test Plan
  1. Check if this not cause errors on equal objects
  2. Check if this shows detailed information what are the differences between objects

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage