Page MenuHomePhabricator
Differential D7803

[keyserver] Add thumbhash to upload endpoints
ClosedPublic
Actions

Authored by bartek on May 15 2023, 1:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 8:03 PM
Unknown Object (File)
Mon, Nov 4, 1:16 PM
Unknown Object (File)
Fri, Nov 1, 12:23 PM
Unknown Object (File)
Wed, Oct 30, 5:57 PM
Unknown Object (File)
Wed, Oct 30, 5:57 PM
Unknown Object (File)
Wed, Oct 30, 5:57 PM
Unknown Object (File)
Wed, Oct 30, 5:57 PM
Unknown Object (File)
Wed, Oct 30, 5:57 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM676e53b30a78: [keyserver] Add thumbhash to upload endpoints
Summary

This adds possibility to store thumbhash on the keyserver. The thumbhash is saved to the extra column of the uploads table. Despite a deditated column being discussed, I decided to use the extras one for the sake of simplicity (avoid migration), and also because there are few other fields to consider when redesigning the uploads table schema (e.g. blob holder or encryption key which are even more important than the thumbhash).

Depends on D7802

Test Plan

Added the thumbhash property to the upload multimedia endpoint call in input-state-container. Checked with TablePlus that it's actually saved to the database.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.May 15 2023, 1:04 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptMay 15 2023, 1:04 AM
bartek added a child revision: D7804: Add thumbhash field to multimedia messages.May 15 2023, 1:10 AM
Harbormaster failed remote builds in B19322: Diff 26436!May 15 2023, 1:20 AM
bartek updated this revision to Diff 26438.May 15 2023, 1:27 AM

fix lint

Harbormaster completed remote builds in B19324: Diff 26438.May 15 2023, 1:44 AM
bartek published this revision for review.May 15 2023, 6:33 AM
ashoat requested changes to this revision.May 15 2023, 12:34 PM

Only requesting changes because I think you accidentally left a sleep call in there

keyserver/src/uploads/media-utils.js
71 ↗(On Diff #26438)

Should eg. inputLoop and inputDimensions be in passthroughParams as well?

keyserver/src/uploads/uploads.js
203 ↗(On Diff #26438)

I think you accidentally left this sleep(3000) in?

lib/actions/upload-actions.js
17–22 ↗(On Diff #26438)
  1. Since it's already wrapped in Shape, the ? should not be necessary (but let me know if I'm missing something)
  2. Should we make this read-only?
This revision now requires changes to proceed.May 15 2023, 12:34 PM
bartek added inline comments.May 16 2023, 3:44 AM
keyserver/src/uploads/media-utils.js
71 ↗(On Diff #26438)

inputLoop can be added, for inputDimensions Flow complains (multiple tuple types)

keyserver/src/uploads/uploads.js
203 ↗(On Diff #26438)

My bad

lib/actions/upload-actions.js
17–22 ↗(On Diff #26438)
  1. Yes, you're right
  1. I think Shape already makes object read-only, that's why it wasn't read-only at first place
export type Shape<O> = $ReadOnly<$Rest<O, { ... }>>;
bartek updated this revision to Diff 26503.May 16 2023, 3:46 AM

Removed accidental sleep. Updated types as suggested

Harbormaster completed remote builds in B19371: Diff 26503.May 16 2023, 4:05 AM
ashoat accepted this revision.May 16 2023, 6:00 AM
ashoat added inline comments.
lib/actions/upload-actions.js
21

Not sure the ? is necessary here – I thought Shape handles this, but I could be wrong

This revision is now accepted and ready to land.May 16 2023, 6:00 AM
bartek updated this revision to Diff 26588.May 17 2023, 3:24 AM

Rebase

Harbormaster completed remote builds in B19438: Diff 26588.May 17 2023, 4:00 AM
Closed by commit rCOMM676e53b30a78: [keyserver] Add thumbhash to upload endpoints (authored by bartek). · Explain WhyMay 17 2023, 4:39 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM676e53b30a78: [keyserver] Add thumbhash to upload endpoints.

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
12 lines
uploads/
21 lines
8 lines
lib/
actions/
6 lines
types/
1 line

Diff 26503

View Options

keyserver/src/creators/upload-creator.js

Loading...
View Options

keyserver/src/uploads/media-utils.js

Loading...
View Options

keyserver/src/uploads/uploads.js

Loading...
View Options

lib/actions/upload-actions.js

Loading...
View Options

lib/types/media-types.js

Loading...