Page MenuHomePhabricator

[native] Add explicit borderColor for non-selected RegistrationTile
ClosedPublic

Authored by ashoat on May 19 2023, 11:31 AM.
Tags
None
Referenced Files
F3369711: D7889.id26708.diff
Mon, Nov 25, 11:19 PM
Unknown Object (File)
Fri, Nov 22, 8:04 AM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:25 AM
Unknown Object (File)
Thu, Nov 14, 11:23 AM
Unknown Object (File)
Thu, Nov 14, 11:00 AM
Unknown Object (File)
Oct 23 2024, 11:08 AM
Unknown Object (File)
Oct 15 2024, 2:59 AM
Subscribers

Details

Summary

This wasn't noticeable in dark mode, but is much more noticeable in light mode. Since we set a borderWidth, React Native color sets a border. I'm not sure how it determines a default color for that border, but I think it just picks black.

Depends on D7888

Test Plan
beforeafter
light mode (not accessible; just showing for context)
Screenshot 2023-05-19 at 2.33.56 PM.png (2×1 px, 868 KB)
Screenshot 2023-05-19 at 2.30.32 PM.png (2×1 px, 866 KB)
dark mode (looks mostly the same)
Screenshot 2023-05-19 at 2.39.13 PM.png (2×1 px, 865 KB)
Screenshot 2023-05-19 at 2.38.56 PM.png (2×1 px, 865 KB)

The only change in dark mode is that the tile looks slightly larger in the "after" version, since we're using the backgroundColor of the tile as the borderColor, instead of using a more black backgroundColor (which fades into the background).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat edited the test plan for this revision. (Show Details)
ashoat edited the test plan for this revision. (Show Details)
ashoat added a reviewer: ted.
This revision is now accepted and ready to land.May 19 2023, 11:50 AM