Paths

Table of Contentst

[native] Introduce `communityCreationButton` to `CommunityDrawerContent`
ClosedPublic
Actions

Authored by atul on May 22 2023, 11:21 AM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM6824f1bb4688: [native] Introduce `communityCreationButton` to `CommunityDrawerContent`

Summary

Add community creation button to community selection drawer.

Just layout/styling for now, functionality will be added in subsequent diff.

Test Plan

Looks as expected (dark mode):

Simulator Screenshot - Fresh iPhone 13 Pro - 2023-05-22 at 14.18.55.png (2×1 px, 269 KB)

Looks as expected (light mode):

Simulator Screenshot - Fresh iPhone 13 Pro - 2023-05-22 at 14.18.45.png (2×1 px, 262 KB)

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D7924 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.May 22 2023, 11:21 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 22 2023, 11:21 AM

atul published this revision for review.May 22 2023, 11:22 AM

atul edited the test plan for this revision. (Show Details)

Make sure Flow etc pass before landing please

native/navigation/community-drawer-content.react.js
120 ↗	(On Diff #26809)	Can we copy `modalSeparator` into `panelSeparator` to avoid mixing families of colors?

This revision is now accepted and ready to land.May 22 2023, 11:26 AM

atul added inline comments.May 22 2023, 11:36 AM

native/navigation/community-drawer-content.react.js
120 ↗	(On Diff #26809)	Ah yeah good point, will update

modalSeparator -> panelSeparator

Herald added a subscriber: • ted. · View Herald TranscriptMay 22 2023, 11:38 AM

Harbormaster completed remote builds in B19614: Diff 26809.May 22 2023, 11:39 AM

rebase and land

Harbormaster completed remote builds in B19615: Diff 26810.May 22 2023, 11:55 AM

This revision was landed with ongoing or failed builds.May 22 2023, 12:02 PM

Closed by commit rCOMM6824f1bb4688: [native] Introduce `communityCreationButton` to `CommunityDrawerContent` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM6824f1bb4688: [native] Introduce `communityCreationButton` to `CommunityDrawerContent`.

Harbormaster completed remote builds in B19616: Diff 26811.May 22 2023, 12:05 PM

Revision Contents
Changeset List

Path

Size

native/

navigation/

community-drawer-content.react.js

48 lines

themes/

colors.js

2 lines

Diff 26811

View Options

native/navigation/community-drawer-content.react.js