See designs here. Some additional comments inline.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- ashoat/registration
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/account/registration/username-selection.react.js | ||
|---|---|---|
| 55–75 | Arguably it's a bit weird to have this JSX in React state. If preferred, I'm open to updating the React state to an enum, and rendering this conditionally based on the enum | |
| 129–143 | I got a lot of these props from RegisterPanel here | |
| 142 | I added this onBlur because I figured that if the user dismisses the keyboard, they might see a gray button and not be clear on why it's gray, and not have any action they can take to figure out what is wrong. In contrast, if the keyboard is up, the gray button isn't visible, and the "Next" button on the keyboard is always pressable (and will yield an error message when pressed if appropriate) | |
| 167 | This is necessary to make sure that the width of "1." is the same as the width of "2.". Otherwise the list for the error state on line 54 looks a bit clunky In a later diff I'll update all body text to use Arial for consistency | |
| 179 | This is pulled from how we render Markdown lists, and is also used in ConnectEthereum | |
Comment Actions
Should we style the input w/ a red outline when there's invalid input + some sort of error state? (cc @ted)
I would expect something more like the right:
Either way, implementation matches the designs
| native/account/registration/username-selection.react.js | ||
|---|---|---|
| 55–75 | Ah yeah, I think either enum or having errorText be some sort of array of strings would be better. Not sure on best practices or whatever, but JSX in state seems unusual | |
Comment Actions
Should we style the input w/ a red outline when there's invalid input + some sort of error state? (cc @ted)
I would expect something more like the right:
Either way, implementation matches the designs
Good call – I agree this makes sense. Thanks for creating DES-89 – I added a concrete question about the new registration flow there in a comment, and assuming we get buy-in from Ted once he's back, I'll implement that change in a later diff.