[native] Use loading button variant in ConnectEthereum during username search
ClosedPublic
Actions

Authored by ashoat on Mon, May 22, 1:00 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMMf3e5e91a3801: [native] Use loading button variant in ConnectEthereum during username search

Summary

Noticed I forgot to do this while working on D7925. See videos in Test Plan to see the impact.

Depends on D7926

Test Plan

To make the loading state clear, I added an artificial 2s delay to the username search keyserver endpoint.

before	after

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mon, May 22, 1:00 PM

Herald added a subscriber: tomek. · View Herald TranscriptMon, May 22, 1:00 PM

ashoat edited the test plan for this revision. (Show Details)Mon, May 22, 1:00 PM

ashoat edited the test plan for this revision. (Show Details)

ashoat added a child revision: D7928: [native] Extract onClose-disabling behavior from SIWEPanel to FullscreenSIWEPanel.Mon, May 22, 1:18 PM

Harbormaster completed remote builds in B19620: Diff 26816.Mon, May 22, 1:21 PM

ashoat requested review of this revision.Mon, May 22, 1:21 PM

atul accepted this revision.Tue, May 23, 5:58 AM

This revision is now accepted and ready to land.Tue, May 23, 5:58 AM

Closed by commit rCOMMf3e5e91a3801: [native] Use loading button variant in ConnectEthereum during username search (authored by ashoat). · Explain WhyTue, May 23, 8:29 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf3e5e91a3801: [native] Use loading button variant in ConnectEthereum during username search.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

connect-ethereum.react.js

16 lines

Diff 26907

View Options

native/account/registration/connect-ethereum.react.js

[native] Use loading button variant in ConnectEthereum during username searchClosedPublicActions