[native] Use loading button variant in ConnectEthereum during username search
ClosedPublic
Actions

Authored by ashoat on May 22 2023, 1:00 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMMf3e5e91a3801: [native] Use loading button variant in ConnectEthereum during username search

Summary

Noticed I forgot to do this while working on D7925. See videos in Test Plan to see the impact.

Depends on D7926

Test Plan

To make the loading state clear, I added an artificial 2s delay to the username search keyserver endpoint.

before	after

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 22 2023, 1:00 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 22 2023, 1:00 PM

ashoat edited the test plan for this revision. (Show Details)May 22 2023, 1:00 PM

ashoat edited the test plan for this revision. (Show Details)

ashoat added a child revision: D7928: [native] Extract onClose-disabling behavior from SIWEPanel to FullscreenSIWEPanel.May 22 2023, 1:18 PM

Harbormaster completed remote builds in B19620: Diff 26816.May 22 2023, 1:21 PM

ashoat requested review of this revision.May 22 2023, 1:21 PM

atul accepted this revision.May 23 2023, 5:58 AM

This revision is now accepted and ready to land.May 23 2023, 5:58 AM

Closed by commit rCOMMf3e5e91a3801: [native] Use loading button variant in ConnectEthereum during username search (authored by ashoat). · Explain WhyMay 23 2023, 8:29 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf3e5e91a3801: [native] Use loading button variant in ConnectEthereum during username search.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

connect-ethereum.react.js

16 lines

Diff 26816

View Options

native/account/registration/connect-ethereum.react.js

[native] Use loading button variant in ConnectEthereum during username searchClosedPublicActions