Paths

Table of Contentst

[native] Move Thumbhash to umbrella expo module
ClosedPublic
Actions

Authored by bartek on May 24 2023, 10:07 AM.

Details

Reviewers

ashoat
atul
marcin

Commits

rCOMM4f16227bca1d: [native] Move Thumbhash to umbrella expo module

Summary

Part of ENG-3871. This diff moves the Thumbhash module to the umbrella expo module.

Basically only moved the files to another directory and updated expo-module.config.json. No more changes are necessary, autolinking does the rest.

Depends on D7962

Test Plan

Built both Android and iOS. Sent multimedia message. Ensured the thumbhash is saved to the keyserver database.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.May 24 2023, 10:07 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptMay 24 2023, 10:07 AM

bartek added a child revision: D7964: [native] Remove HelloWorld expo module.May 24 2023, 10:08 AM

Harbormaster completed remote builds in B19748: Diff 27007.May 24 2023, 10:25 AM

bartek published this revision for review.May 24 2023, 10:33 AM

ashoat accepted this revision.May 24 2023, 11:17 AM

This revision is now accepted and ready to land.May 24 2023, 11:17 AM

Closed by commit rCOMM4f16227bca1d: [native] Move Thumbhash to umbrella expo module (authored by bartek). · Explain WhyMay 24 2023, 11:24 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM4f16227bca1d: [native] Move Thumbhash to umbrella expo module.

Revision Contents
Changeset List

Path

Size

.dockerignore

1 line

keyserver/

Dockerfile

2 lines

native/

expo-modules/

	comm-expo-package/
	thumbhash/

android/

src/

main/

java/

app/

comm/

android/

thumbhash/

ThumbhashModule.kt

112 lines

thirdparty/

LICENSE.txt

19 lines

ThumbHash.java

148 lines

ios/

ThumbhashModule.swift

28 lines

third_party/

LICENSE.txt

19 lines

Thumbhash.swift

294 lines

comm-expo-package/

expo-module.config.json

5 lines

thumbhash/

android/

build.gradle

src/

main/

AndroidManifest.xml

java/

app/

comm/

android/

thumbhash/

ThumbhashModule.kt

thirdparty/

LICENSE.txt

ThumbHash.java

expo-module.config.json

ios/

Thumbhash.podspec

ThumbhashModule.swift

third_party/

ios/

6 lines

1 line

1 line

Diff 27007

View Options

.dockerignore

View Options

keyserver/Dockerfile

View Options

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/thumbhash/ThumbhashModule.kt

View Options

native/expo-modules/comm-expo-package/android/src/main/java/thirdparty/LICENSE.txt

View Options

native/expo-modules/comm-expo-package/android/src/main/java/thirdparty/ThumbHash.java

View Options

native/expo-modules/comm-expo-package/expo-module.config.json

View Options

native/expo-modules/comm-expo-package/ios/ThumbhashModule.swift

View Options

native/expo-modules/comm-expo-package/ios/third_party/LICENSE.txt

View Options

native/expo-modules/comm-expo-package/ios/third_party/Thumbhash.swift

View Options

native/expo-modules/thumbhash/android/build.gradle

View Options

native/expo-modules/thumbhash/android/src/main/AndroidManifest.xml

View Options

native/expo-modules/thumbhash/android/src/main/java/app/comm/android/thumbhash/ThumbhashModule.kt

View Options

native/expo-modules/thumbhash/android/src/main/java/thirdparty/LICENSE.txt

View Options

native/expo-modules/thumbhash/android/src/main/java/thirdparty/ThumbHash.java

View Options

native/expo-modules/thumbhash/expo-module.config.json

View Options

native/expo-modules/thumbhash/ios/Thumbhash.podspec

View Options

native/expo-modules/thumbhash/ios/ThumbhashModule.swift

View Options

native/expo-modules/thumbhash/ios/third_party/LICENSE.txt

View Options

native/expo-modules/thumbhash/ios/third_party/Thumbhash.swift

View Options

native/expo-modules/thumbhash/package.json

View Options

native/ios/Podfile.lock

View Options

native/package.json

View Options

[native] Move Thumbhash to umbrella expo moduleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27007

.dockerignore

keyserver/Dockerfile

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/thumbhash/ThumbhashModule.kt

native/expo-modules/comm-expo-package/android/src/main/java/thirdparty/LICENSE.txt

native/expo-modules/comm-expo-package/android/src/main/java/thirdparty/ThumbHash.java

native/expo-modules/comm-expo-package/expo-module.config.json

native/expo-modules/comm-expo-package/ios/ThumbhashModule.swift

native/expo-modules/comm-expo-package/ios/third_party/LICENSE.txt

native/expo-modules/comm-expo-package/ios/third_party/Thumbhash.swift

native/expo-modules/thumbhash/android/build.gradle

native/expo-modules/thumbhash/android/src/main/AndroidManifest.xml

native/expo-modules/thumbhash/android/src/main/java/app/comm/android/thumbhash/ThumbhashModule.kt

native/expo-modules/thumbhash/android/src/main/java/thirdparty/LICENSE.txt

native/expo-modules/thumbhash/android/src/main/java/thirdparty/ThumbHash.java

native/expo-modules/thumbhash/expo-module.config.json

native/expo-modules/thumbhash/ios/Thumbhash.podspec

native/expo-modules/thumbhash/ios/ThumbhashModule.swift

native/expo-modules/thumbhash/ios/third_party/LICENSE.txt

native/expo-modules/thumbhash/ios/third_party/Thumbhash.swift

native/expo-modules/thumbhash/package.json

native/ios/Podfile.lock

native/package.json

package.json

[native] Move Thumbhash to umbrella expo module
ClosedPublic
Actions

Revision Contents
Changeset List