Page MenuHomePhabricator
Differential D7971

[web] Disabled edit button if edited message is empty
ClosedPublic
Actions

Authored by • kuba on May 25 2023, 2:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 6:48 PM
Unknown Object (File)
Thu, Dec 5, 2:30 AM
Unknown Object (File)
Thu, Dec 5, 2:30 AM
Unknown Object (File)
Thu, Dec 5, 2:29 AM
Unknown Object (File)
Thu, Dec 5, 2:29 AM
Unknown Object (File)
Wed, Dec 4, 2:41 PM
Unknown Object (File)
Wed, Dec 4, 2:41 PM
Unknown Object (File)
Wed, Dec 4, 2:41 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
Commits
rCOMM71c5fc52caae: [web] Disabled edit button if edited message is empty
Summary

We want to match editing behavior with the native. If the user types an empty message, the edit button will be disabled, and the user will be prevented from saving the changes.

Test Plan
  • Entered edit mode of a message.
  • Cleared the whole message.
  • Checked if the edit button is disabled.
  • Typed some spaces.
  • Checked if the edit button is still disabled.
  • Typed some text.
  • Checked if the edit button is enabled.

Diff Detail

Repository
rCOMM Comm
Branch
kuba/empty_messages_web
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.May 25 2023, 2:18 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 25 2023, 2:18 AM
• kuba added inline comments.May 25 2023, 2:19 AM
web/chat/edit-text-message.react.js
66–68 ↗(On Diff #27042)

We don't want to let users send empty messages.

Harbormaster completed remote builds in B19760: Diff 27042.May 25 2023, 2:36 AM
• kuba requested review of this revision.May 25 2023, 2:36 AM
ashoat added inline comments.May 25 2023, 3:59 AM
web/chat/edit-text-message.react.js
48–50 ↗(On Diff #27042)

Shorthand

michal accepted this revision.May 25 2023, 4:31 AM
This revision is now accepted and ready to land.May 25 2023, 4:31 AM
• kuba updated this revision to Diff 27045.May 25 2023, 4:37 AM
• kuba marked an inline comment as done.

Shorthand

This revision was landed with ongoing or failed builds.May 25 2023, 4:39 AM
Closed by commit rCOMM71c5fc52caae: [web] Disabled edit button if edited message is empty (authored by kosmydel <kukubaczek@gmail.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMM71c5fc52caae: [web] Disabled edit button if edited message is empty.
Harbormaster completed remote builds in B19762: Diff 27045.May 25 2023, 4:55 AM

Revision Contents
Changeset List

PathSize
web/
chat/
9 lines

Diff 27045

View Options

web/chat/edit-text-message.react.js

Loading...