This differential exports CommValidationModule to JavaScript.
Details
Details
- Reviewers
bartek atul - Commits
- rCOMM2ae9682a129a: Export CommConstants HostObject to JavaScript
I decided to call commConstants.NATIVE_MESSAGE_SPECS in sqlite-data-handler.js for testing purposes. So the test plan is:
- Build the app
- Apply this diff: https://gist.github.com/marcinwasowicz/da35ee527660a6a020daf88ddae61d24
- Open the app. Ensure the warning message like this is visible:
Object { "message": "C++ MessageSpec implementation missing for message types: ADD_MEMBERS, REMOVE_MEMBERS, LEAVE_THREAD, JOIN_THREAD, TOGGLE_PIN", }
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-1159
- Lint
No Lint Coverage - Unit
No Test Coverage