Page MenuHomePhabricator
Differential D8118

[web-db] add `extractable` param while creating crypto key
ClosedPublic
Actions

Authored by kamil on Jun 6 2023, 10:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 16, 5:29 AM
Unknown Object (File)
Mar 13 2025, 6:15 AM
Unknown Object (File)
Mar 13 2025, 6:15 AM
Unknown Object (File)
Mar 13 2025, 6:15 AM
Unknown Object (File)
Mar 13 2025, 6:15 AM
Unknown Object (File)
Mar 13 2025, 6:12 AM
Unknown Object (File)
Feb 25 2025, 4:57 AM
Unknown Object (File)
Feb 24 2025, 3:05 PM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMM6d91d8394f5c: [web-db] add `extractable` param while creating crypto key
Summary

On Safari we need to export the key to send this to worker in form it is transferable. (context)

Depends on D8117

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jun 6 2023, 10:08 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJun 6 2023, 10:08 AM
kamil added a child revision: D8119: [web-db] add methods to import/export key to `JWK` format.Jun 6 2023, 10:09 AM
Harbormaster completed remote builds in B20055: Diff 27485.Jun 6 2023, 10:25 AM
kamil published this revision for review.Jun 7 2023, 1:36 AM
kamil added inline comments.
web/database/utils/worker-crypto-utils.js
11 ↗(On Diff #27485)

this could be one argument but in this case, I want this to be more descriptive from caller's perspective

ashoat added inline comments.Jun 7 2023, 2:07 PM
web/database/utils/worker-crypto-utils.js
13 ↗(On Diff #27485)

Inputs should always be $ReadOnly

tomek accepted this revision.Jun 13 2023, 3:26 AM
This revision is now accepted and ready to land.Jun 13 2023, 3:26 AM
kamil updated this revision to Diff 27747.Jun 14 2023, 7:05 AM

make params read-only

This revision was landed with ongoing or failed builds.Jun 14 2023, 10:14 AM
Closed by commit rCOMM6d91d8394f5c: [web-db] add `extractable` param while creating crypto key (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM6d91d8394f5c: [web-db] add `extractable` param while creating crypto key.

Revision Contents
Changeset List

PathSize
web/
database/
utils/
8 lines
6 lines
worker/
4 lines

Diff 27747

View Options

web/database/utils/worker-crypto-utils.js

Show All 34 Linesvoid AmqpManager::connectInternal() {
this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection); this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);
this->amqpChannel->onError([this](const char *message) { this->amqpChannel->onError([this](const char *message) {
LOG(ERROR) << "AMQP: channel error: " << message LOG(ERROR) << "AMQP: channel error: " << message
<< ", will try to reconnect"; << ", will try to reconnect";
this->amqpReady = false; this->amqpReady = false;
}); });
AMQP::Table arguments; AMQP::Table arguments;
arguments["x-message-ttl"] = AMQP_MESSAGE_TTL; arguments["x-message-ttl"] = (uint64_t)AMQP_MESSAGE_TTL;
arguments["x-expires"] = AMQP_QUEUE_TTL; arguments["x-expires"] = (uint64_t)AMQP_QUEUE_TTL;
this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout); this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);
this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments) this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)
.onSuccess([this, tunnelbrokerID, fanoutExchangeName]( .onSuccess([this, tunnelbrokerID, fanoutExchangeName](
const std::string &name, const std::string &name,
uint32_t messagecount, uint32_t messagecount,
uint32_t consumercount) { uint32_t consumercount) {
LOG(INFO) << "AMQP: Queue " << name << " created"; LOG(INFO) << "AMQP: Queue " << name << " created";
this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "") this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines
View Options

web/database/utils/worker-crypto-utlis.test.js

Show All 34 Linesvoid AmqpManager::connectInternal() {
this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection); this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);
this->amqpChannel->onError([this](const char *message) { this->amqpChannel->onError([this](const char *message) {
LOG(ERROR) << "AMQP: channel error: " << message LOG(ERROR) << "AMQP: channel error: " << message
<< ", will try to reconnect"; << ", will try to reconnect";
this->amqpReady = false; this->amqpReady = false;
}); });
AMQP::Table arguments; AMQP::Table arguments;
arguments["x-message-ttl"] = AMQP_MESSAGE_TTL; arguments["x-message-ttl"] = (uint64_t)AMQP_MESSAGE_TTL;
arguments["x-expires"] = AMQP_QUEUE_TTL; arguments["x-expires"] = (uint64_t)AMQP_QUEUE_TTL;
this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout); this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);
this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments) this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)
.onSuccess([this, tunnelbrokerID, fanoutExchangeName]( .onSuccess([this, tunnelbrokerID, fanoutExchangeName](
const std::string &name, const std::string &name,
uint32_t messagecount, uint32_t messagecount,
uint32_t consumercount) { uint32_t consumercount) {
LOG(INFO) << "AMQP: Queue " << name << " created"; LOG(INFO) << "AMQP: Queue " << name << " created";
this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "") this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines
View Options

web/database/worker/db-worker.js

Show All 34 Linesvoid AmqpManager::connectInternal() {
this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection); this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);
this->amqpChannel->onError([this](const char *message) { this->amqpChannel->onError([this](const char *message) {
LOG(ERROR) << "AMQP: channel error: " << message LOG(ERROR) << "AMQP: channel error: " << message
<< ", will try to reconnect"; << ", will try to reconnect";
this->amqpReady = false; this->amqpReady = false;
}); });
AMQP::Table arguments; AMQP::Table arguments;
arguments["x-message-ttl"] = AMQP_MESSAGE_TTL; arguments["x-message-ttl"] = (uint64_t)AMQP_MESSAGE_TTL;
arguments["x-expires"] = AMQP_QUEUE_TTL; arguments["x-expires"] = (uint64_t)AMQP_QUEUE_TTL;
this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout); this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);
this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments) this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)
.onSuccess([this, tunnelbrokerID, fanoutExchangeName]( .onSuccess([this, tunnelbrokerID, fanoutExchangeName](
const std::string &name, const std::string &name,
uint32_t messagecount, uint32_t messagecount,
uint32_t consumercount) { uint32_t consumercount) {
LOG(INFO) << "AMQP: Queue " << name << " created"; LOG(INFO) << "AMQP: Queue " << name << " created";
this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "") this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines