Details

Reviewers

atul
ashoat
• jon

Commits

rCOMMcaf85e1e400a: [keyserver] call identity service during account creation and deletion

Summary

when we create a new account with a username, we should add it to the reserved usernames list
being maintained by the identity service.

when we delete an existing account with a username, we should remove it from the reserved usernames list being maintained by the identity service.

Depends on D8299

Test Plan

tested this by creating and deleting a new user locally. saw that the username was added to and then removed from my ddb table in localstack.

also tried removing a reserved username that didn't exist in ddb and got back an error as expected.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jun 22 2023, 11:46 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 22 2023, 11:46 PM

fix import duplication

Harbormaster failed remote builds in B20446: Diff 28028!Jun 22 2023, 11:58 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2023, 12:12 AM

Harbormaster failed remote builds in B20447: Diff 28029!

changes to satisfy jest

Harbormaster completed remote builds in B20484: Diff 28070.Jun 23 2023, 1:40 PM

varun requested review of this revision.Jun 23 2023, 1:40 PM

Seems right at a high level, adding @ashoat as blocking to take a look at babel-plugin-transform-import-meta dependency and related changes.

keyserver/src/creators/account-creator.js
220 ↗	(On Diff #28070)	Should this "magic string" be defined somewhere that's shared?

varun added inline comments.Jun 26 2023, 11:33 AM

keyserver/src/creators/account-creator.js
220 ↗	(On Diff #28070)	that's a fair point

address feedback

varun added a parent revision: D8328: change AddReservedUsername to AddReservedUsernames.Jun 27 2023, 7:01 AM

Harbormaster completed remote builds in B20539: Diff 28166.Jun 27 2023, 7:18 AM

varun added a child revision: D8330: [keyserver] fetchUsernames helper function.Jun 27 2023, 7:46 AM

varun mentioned this in D8331: [keyserver] cron job to sync reserved usernames.Jun 27 2023, 8:27 AM

This diff should be split, and more work should be done to explain the changes and why they're necessary

keyserver/addons/rust-node-addon/index.js
16–19	No idea what this is about or why it's being introduced! This needs to be explained in the diff description...
keyserver/babel.config.cjs
11	No idea why this is necessary
keyserver/package.json
34	It really would've made it easier to review if you had split this part out into its own diff
keyserver/src/shared/message-statements.js
3–7	Why do these need to be human-readable? Does this need to be synced with some equivalent strings on the Rust side? If so, it would be better to avoid the copy-paste, but if it's necessary then you need to do some extra work to make sure the reader is aware of this strong requirement. Otherwise it's really easy for the expectation to be broken, as you've done nothing to make the requirement discoverable
lib/types/crypto-types.js
43	Why don't we always take a `$ReadOnlyArray<string>`? If there's some strong reason we need to take `string \| $ReadOnlyArray<string>, then I think we should type it that way, and avoid generics. I suspect that the payload needs to be a specific format for the Rust call, so we should enforce that on the JS side

This revision now requires changes to proceed.Jun 28 2023, 5:26 PM

ashoat added inline comments.Jun 28 2023, 5:31 PM

lib/types/crypto-types.js

41–45

I think this would be a better type:

export type ReservedUsernameMessage = {
  +mutationType: 'add' | 'remove',
  +userIDs: $ReadOnlyArray<string>,
  +issuedAt: string,
};

If you absolutely need to make the payload only take a single string for deletes, you could do this:

export type ReservedUsernameMessage =
  | {
      +mutationType: 'add',
      +userIDs: $ReadOnlyArray<string>,
      +issuedAt: string,
    }
  | {
      +mutationType: 'remove',
      +userID: string,
      +issuedAt: string,
    };

address feedback

varun added a parent revision: D8406: [keyserver] Add conditional handling for import.meta in tests and update Babel configuration.Jun 30 2023, 9:40 PM

varun removed a parent revision: D8328: change AddReservedUsername to AddReservedUsernames.

Harbormaster completed remote builds in B20667: Diff 28323.Jun 30 2023, 9:58 PM

varun added inline comments.Jun 30 2023, 9:59 PM

keyserver/addons/rust-node-addon/index.js
16–19	split this out into a separate diff
keyserver/babel.config.cjs
11	this is in a separate diff now
keyserver/src/shared/message-statements.js
3–7	it doesn't need to be human-readable, actually. we can simplify this. follow up task: https://linear.app/comm/issue/ENG-4296/reduce-message-statement-to-just-a-verb
lib/types/crypto-types.js
41–45	to avoid making changes on the identity service, i'm doing the following for now: export type ReservedUsernameMessage = \| { +statement: 'Add the following usernames to reserved list', +payload: $ReadOnlyArray<string>, +issuedAt: string, } \| { +statement: 'Remove the following username from reserved list', +payload: string, +issuedAt: string, }; will address further type improvements in this follow-up task: https://linear.app/comm/issue/ENG-4295/simplify-reservedusernamemessage-type-on-keyserver
43	Why don't we always take a $ReadOnlyArray<string>? we don't have a use case for a batch delete, but this would simplify things a bit on the keyserver side. created a follow-up task: https://linear.app/comm/issue/ENG-4294/update-removereservedusername-rpc-to-take-a-list-of-usernames