Page MenuHomePhabricator
Differential D8300

[keyserver] call identity service during account creation and deletion
ClosedPublic
Actions

Authored by varun on Jun 22 2023, 11:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 2:56 PM
Unknown Object (File)
Wed, Mar 12, 11:59 AM
Unknown Object (File)
Tue, Mar 11, 3:05 PM
Unknown Object (File)
Thu, Mar 6, 5:45 AM
Unknown Object (File)
Mar 1 2025, 2:57 AM
Unknown Object (File)
Feb 26 2025, 4:03 AM
Unknown Object (File)
Feb 22 2025, 7:35 PM
Unknown Object (File)
Feb 20 2025, 4:59 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ashoat
• jon
Commits
rCOMMcaf85e1e400a: [keyserver] call identity service during account creation and deletion
Summary

when we create a new account with a username, we should add it to the reserved usernames list
being maintained by the identity service.

when we delete an existing account with a username, we should remove it from the reserved usernames list being maintained by the identity service.

Depends on D8299

Test Plan

tested this by creating and deleting a new user locally. saw that the username was added to and then removed from my ddb table in localstack.

also tried removing a reserved username that didn't exist in ddb and got back an error as expected.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jun 22 2023, 11:46 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 22 2023, 11:46 PM
varun updated this revision to Diff 28029.Jun 22 2023, 11:56 PM

fix import duplication

Harbormaster failed remote builds in B20446: Diff 28028!Jun 22 2023, 11:58 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2023, 12:12 AM
Harbormaster failed remote builds in B20447: Diff 28029!
varun updated this revision to Diff 28070.Jun 23 2023, 1:21 PM

changes to satisfy jest

Harbormaster completed remote builds in B20484: Diff 28070.Jun 23 2023, 1:40 PM
varun requested review of this revision.Jun 23 2023, 1:40 PM
atul accepted this revision.Jun 26 2023, 7:26 AM
atul added a reviewer: ashoat.

Seems right at a high level, adding @ashoat as blocking to take a look at babel-plugin-transform-import-meta dependency and related changes.

keyserver/src/creators/account-creator.js
220 ↗(On Diff #28070)

Should this "magic string" be defined somewhere that's shared?

varun added inline comments.Jun 26 2023, 11:33 AM
keyserver/src/creators/account-creator.js
220 ↗(On Diff #28070)

that's a fair point

varun updated this revision to Diff 28166.Jun 27 2023, 7:00 AM

address feedback

varun added a parent revision: D8328: change AddReservedUsername to AddReservedUsernames.Jun 27 2023, 7:01 AM
Harbormaster completed remote builds in B20539: Diff 28166.Jun 27 2023, 7:18 AM
varun added a child revision: D8330: [keyserver] fetchUsernames helper function.Jun 27 2023, 7:46 AM
varun mentioned this in D8331: [keyserver] cron job to sync reserved usernames.Jun 27 2023, 8:27 AM
ashoat requested changes to this revision.Jun 28 2023, 5:26 PM

This diff should be split, and more work should be done to explain the changes and why they're necessary

keyserver/addons/rust-node-addon/index.js
16–19

No idea what this is about or why it's being introduced! This needs to be explained in the diff description...

keyserver/babel.config.cjs
11

No idea why this is necessary

keyserver/package.json
34

It really would've made it easier to review if you had split this part out into its own diff

keyserver/src/shared/message-statements.js
3–7
  1. Why do these need to be human-readable?
  2. Does this need to be synced with some equivalent strings on the Rust side? If so, it would be better to avoid the copy-paste, but if it's necessary then you need to do some extra work to make sure the reader is aware of this strong requirement. Otherwise it's really easy for the expectation to be broken, as you've done nothing to make the requirement discoverable
lib/types/crypto-types.js
43
  1. Why don't we always take a $ReadOnlyArray<string>?
  2. If there's some strong reason we need to take `string | $ReadOnlyArray<string>, then I think we should type it that way, and avoid generics. I suspect that the payload needs to be a specific format for the Rust call, so we should enforce that on the JS side
This revision now requires changes to proceed.Jun 28 2023, 5:26 PM
ashoat added inline comments.Jun 28 2023, 5:31 PM
lib/types/crypto-types.js
41–45

I think this would be a better type:

export type ReservedUsernameMessage = {
  +mutationType: 'add' | 'remove',
  +userIDs: $ReadOnlyArray<string>,
  +issuedAt: string,
};

If you absolutely need to make the payload only take a single string for deletes, you could do this:

export type ReservedUsernameMessage =
  | {
      +mutationType: 'add',
      +userIDs: $ReadOnlyArray<string>,
      +issuedAt: string,
    }
  | {
      +mutationType: 'remove',
      +userID: string,
      +issuedAt: string,
    };
varun updated this revision to Diff 28323.Jun 30 2023, 9:40 PM
varun marked 3 inline comments as done.

address feedback

varun added a parent revision: D8406: [keyserver] Add conditional handling for import.meta in tests and update Babel configuration.Jun 30 2023, 9:40 PM
varun removed a parent revision: D8328: change AddReservedUsername to AddReservedUsernames.
Harbormaster completed remote builds in B20667: Diff 28323.Jun 30 2023, 9:58 PM
varun added inline comments.Jun 30 2023, 9:59 PM
keyserver/addons/rust-node-addon/index.js
16–19

split this out into a separate diff

keyserver/babel.config.cjs
11

this is in a separate diff now

keyserver/src/shared/message-statements.js
3–7

it doesn't need to be human-readable, actually. we can simplify this. follow up task: https://linear.app/comm/issue/ENG-4296/reduce-message-statement-to-just-a-verb

lib/types/crypto-types.js
41–45

to avoid making changes on the identity service, i'm doing the following for now:

export type ReservedUsernameMessage =
  | {
      +statement: 'Add the following usernames to reserved list',
      +payload: $ReadOnlyArray<string>,
      +issuedAt: string,
    }
  | {
      +statement: 'Remove the following username from reserved list',
      +payload: string,
      +issuedAt: string,
    };

will address further type improvements in this follow-up task: https://linear.app/comm/issue/ENG-4295/simplify-reservedusernamemessage-type-on-keyserver

43

Why don't we always take a $ReadOnlyArray<string>?

we don't have a use case for a batch delete, but this would simplify things a bit on the keyserver side. created a follow-up task: https://linear.app/comm/issue/ENG-4294/update-removereservedusername-rpc-to-take-a-list-of-usernames

ashoat accepted this revision.Jul 2 2023, 11:36 AM
ashoat added inline comments.
lib/types/crypto-types.js
42 ↗(On Diff #28323)

Can you make sure we add the equivalent text on the Rust side?

This revision is now accepted and ready to land.Jul 2 2023, 11:36 AM
Closed by commit rCOMMcaf85e1e400a: [keyserver] call identity service during account creation and deletion (authored by varun). · Explain WhyJul 3 2023, 8:39 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMcaf85e1e400a: [keyserver] call identity service during account creation and deletion.
Herald added a reviewer: • jon. · View Herald TranscriptJul 3 2023, 8:39 PM
varun mentioned this in D8533: [keyserver] rename napi add_reserved_usernames function.Jul 18 2023, 12:38 PM
varun mentioned this in rCOMMeabd32112e35: [keyserver] rename napi add_reserved_usernames function.Jul 18 2023, 2:24 PM

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
30 lines
6 lines
1 line
src/
creators/
29 lines
deleters/
31 lines
shared/
9 lines
lib/
types/
6 lines
57 lines

Diff 28166

View Options

keyserver/addons/rust-node-addon/index.js

// @flow // @flow
import { HeaderBackButton as BaseHeaderBackButton } from '@react-navigation/elements'; import { HeaderBackButton as BaseHeaderBackButton } from '@react-navigation/elements';
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { Text } from 'react-native'; import { Alert, Text } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import type { NavigationRoute } from '../navigation/route-names';
import { useColors } from '../themes/colors.js'; import { useColors } from '../themes/colors.js';
type Props = React.ElementConfig<typeof BaseHeaderBackButton>; type ChangeRolesHeaderLeftButtonProps = {
function ChangeRolesHeaderLeftButton(props: Props): React.Node { +route: NavigationRoute<'ChangeRolesScreen'>,
...React.ElementConfig<typeof BaseHeaderBackButton>,
};
function ChangeRolesHeaderLeftButton(
props: ChangeRolesHeaderLeftButtonProps,
): React.Node {
const { memberInfo, role: selectedRole } = props.route.params;
const { role: memberRole } = memberInfo;
const onCancel = React.useCallback(() => {
const { onPress } = props;
invariant(onPress, 'onPress must be defined');
if (selectedRole === memberRole) {
onPress();
return;
}
Alert.alert(
'Unsaved Changes',
'You have unsaved changes, are you sure you want to cancel? You will lose all your progress',
[
{ text: 'Cancel', onPress },
{ text: 'Stay', style: 'cancel' },
],
{ cancelable: true },
);
}, [memberRole, props, selectedRole]);
rohanAuthorUnsubmitted
Done
Inline Actions

I think the wording here may be a bit confusing. In my experience, 'cancel' typically means close the alert, and there's another option like 'confirm' or something that will mean you're ok with discarding changes.

Here it seems like 'cancel' means we're ok with discarding changes. Not sure if it's just me though (cc @ted)

rohan: I think the wording here may be a bit confusing. In my experience, 'cancel' typically means…
ashoatUnsubmitted
Not Done
Inline Actions

What do we do in the current edit-message workflow? Heads-up I generally handle copy, not @ted

ashoat: What do we do in the current edit-message workflow? Heads-up I generally handle copy, not @ted
rohanAuthorUnsubmitted
Done
Inline Actions

Ah my bad. It looks like in message editing: Continue editing closes the alert and continues editing while Discard edit closes the alert and exits editing

rohan: Ah my bad. It looks like in message editing: `Continue editing` closes the alert and continues…
ashoatUnsubmitted
Not Done
Inline Actions
  1. I agree we shouldn't use the term Cancel here... how about Leave?
  2. I don't think we need { cancelable: true }... we can just default to Stay if the user dismisses the Alert
  3. Can we try to match copy for title / description with the edit-message workflow?
ashoat: 1. I agree we shouldn't use the term `Cancel` here... how about `Leave`? 2. I don't think we…
rohanAuthorUnsubmitted
Done
Inline Actions

Yeah that makes sense, I'll update the diff

rohan: Yeah that makes sense, I'll update the diff
const { panelForegroundSecondaryLabel } = useColors(); const { panelForegroundSecondaryLabel } = useColors();
const labelStyle = React.useMemo( const labelStyle = React.useMemo(
() => ({ () => ({
color: panelForegroundSecondaryLabel, color: panelForegroundSecondaryLabel,
marginLeft: 10, marginLeft: 10,
}), }),
[panelForegroundSecondaryLabel], [panelForegroundSecondaryLabel],
); );
return ( return (
<TouchableOpacity onPress={props.onPress}> <TouchableOpacity onPress={onCancel}>
<Text style={labelStyle}>Cancel</Text> <Text style={labelStyle}>Cancel</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
export default ChangeRolesHeaderLeftButton; export default ChangeRolesHeaderLeftButton;
View Options

keyserver/babel.config.cjs

// @flow // @flow
import { HeaderBackButton as BaseHeaderBackButton } from '@react-navigation/elements'; import { HeaderBackButton as BaseHeaderBackButton } from '@react-navigation/elements';
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { Text } from 'react-native'; import { Alert, Text } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import type { NavigationRoute } from '../navigation/route-names';
import { useColors } from '../themes/colors.js'; import { useColors } from '../themes/colors.js';
type Props = React.ElementConfig<typeof BaseHeaderBackButton>; type ChangeRolesHeaderLeftButtonProps = {
function ChangeRolesHeaderLeftButton(props: Props): React.Node { +route: NavigationRoute<'ChangeRolesScreen'>,
...React.ElementConfig<typeof BaseHeaderBackButton>,
};
function ChangeRolesHeaderLeftButton(
props: ChangeRolesHeaderLeftButtonProps,
): React.Node {
const { memberInfo, role: selectedRole } = props.route.params;
const { role: memberRole } = memberInfo;
const onCancel = React.useCallback(() => {
const { onPress } = props;
invariant(onPress, 'onPress must be defined');
if (selectedRole === memberRole) {
onPress();
return;
}
Alert.alert(
'Unsaved Changes',
'You have unsaved changes, are you sure you want to cancel? You will lose all your progress',
[
{ text: 'Cancel', onPress },
{ text: 'Stay', style: 'cancel' },
],
{ cancelable: true },
);
}, [memberRole, props, selectedRole]);
rohanAuthorUnsubmitted
Done
Inline Actions

I think the wording here may be a bit confusing. In my experience, 'cancel' typically means close the alert, and there's another option like 'confirm' or something that will mean you're ok with discarding changes.

Here it seems like 'cancel' means we're ok with discarding changes. Not sure if it's just me though (cc @ted)

rohan: I think the wording here may be a bit confusing. In my experience, 'cancel' typically means…
ashoatUnsubmitted
Not Done
Inline Actions

What do we do in the current edit-message workflow? Heads-up I generally handle copy, not @ted

ashoat: What do we do in the current edit-message workflow? Heads-up I generally handle copy, not @ted
rohanAuthorUnsubmitted
Done
Inline Actions

Ah my bad. It looks like in message editing: Continue editing closes the alert and continues editing while Discard edit closes the alert and exits editing

rohan: Ah my bad. It looks like in message editing: `Continue editing` closes the alert and continues…
ashoatUnsubmitted
Not Done
Inline Actions
  1. I agree we shouldn't use the term Cancel here... how about Leave?
  2. I don't think we need { cancelable: true }... we can just default to Stay if the user dismisses the Alert
  3. Can we try to match copy for title / description with the edit-message workflow?
ashoat: 1. I agree we shouldn't use the term `Cancel` here... how about `Leave`? 2. I don't think we…
rohanAuthorUnsubmitted
Done
Inline Actions

Yeah that makes sense, I'll update the diff

rohan: Yeah that makes sense, I'll update the diff
const { panelForegroundSecondaryLabel } = useColors(); const { panelForegroundSecondaryLabel } = useColors();
const labelStyle = React.useMemo( const labelStyle = React.useMemo(
() => ({ () => ({
color: panelForegroundSecondaryLabel, color: panelForegroundSecondaryLabel,
marginLeft: 10, marginLeft: 10,
}), }),
[panelForegroundSecondaryLabel], [panelForegroundSecondaryLabel],
); );
return ( return (
<TouchableOpacity onPress={props.onPress}> <TouchableOpacity onPress={onCancel}>
<Text style={labelStyle}>Cancel</Text> <Text style={labelStyle}>Cancel</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
export default ChangeRolesHeaderLeftButton; export default ChangeRolesHeaderLeftButton;
View Options

keyserver/package.json

// @flow // @flow
import { HeaderBackButton as BaseHeaderBackButton } from '@react-navigation/elements'; import { HeaderBackButton as BaseHeaderBackButton } from '@react-navigation/elements';
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { Text } from 'react-native'; import { Alert, Text } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import type { NavigationRoute } from '../navigation/route-names';
import { useColors } from '../themes/colors.js'; import { useColors } from '../themes/colors.js';
type Props = React.ElementConfig<typeof BaseHeaderBackButton>; type ChangeRolesHeaderLeftButtonProps = {
function ChangeRolesHeaderLeftButton(props: Props): React.Node { +route: NavigationRoute<'ChangeRolesScreen'>,
...React.ElementConfig<typeof BaseHeaderBackButton>,
};
function ChangeRolesHeaderLeftButton(
props: ChangeRolesHeaderLeftButtonProps,
): React.Node {
const { memberInfo, role: selectedRole } = props.route.params;
const { role: memberRole } = memberInfo;
const onCancel = React.useCallback(() => {
const { onPress } = props;
invariant(onPress, 'onPress must be defined');
if (selectedRole === memberRole) {
onPress();
return;
}
Alert.alert(
'Unsaved Changes',
'You have unsaved changes, are you sure you want to cancel? You will lose all your progress',
[
{ text: 'Cancel', onPress },
{ text: 'Stay', style: 'cancel' },
],
{ cancelable: true },
);
}, [memberRole, props, selectedRole]);
rohanAuthorUnsubmitted
Done
Inline Actions

I think the wording here may be a bit confusing. In my experience, 'cancel' typically means close the alert, and there's another option like 'confirm' or something that will mean you're ok with discarding changes.

Here it seems like 'cancel' means we're ok with discarding changes. Not sure if it's just me though (cc @ted)

rohan: I think the wording here may be a bit confusing. In my experience, 'cancel' typically means…
ashoatUnsubmitted
Not Done
Inline Actions

What do we do in the current edit-message workflow? Heads-up I generally handle copy, not @ted

ashoat: What do we do in the current edit-message workflow? Heads-up I generally handle copy, not @ted
rohanAuthorUnsubmitted
Done
Inline Actions

Ah my bad. It looks like in message editing: Continue editing closes the alert and continues editing while Discard edit closes the alert and exits editing

rohan: Ah my bad. It looks like in message editing: `Continue editing` closes the alert and continues…
ashoatUnsubmitted
Not Done
Inline Actions
  1. I agree we shouldn't use the term Cancel here... how about Leave?
  2. I don't think we need { cancelable: true }... we can just default to Stay if the user dismisses the Alert
  3. Can we try to match copy for title / description with the edit-message workflow?
ashoat: 1. I agree we shouldn't use the term `Cancel` here... how about `Leave`? 2. I don't think we…
rohanAuthorUnsubmitted
Done
Inline Actions

Yeah that makes sense, I'll update the diff

rohan: Yeah that makes sense, I'll update the diff
const { panelForegroundSecondaryLabel } = useColors(); const { panelForegroundSecondaryLabel } = useColors();
const labelStyle = React.useMemo( const labelStyle = React.useMemo(
() => ({ () => ({
color: panelForegroundSecondaryLabel, color: panelForegroundSecondaryLabel,
marginLeft: 10, marginLeft: 10,
}), }),
[panelForegroundSecondaryLabel], [panelForegroundSecondaryLabel],
); );
return ( return (
<TouchableOpacity onPress={props.onPress}> <TouchableOpacity onPress={onCancel}>
<Text style={labelStyle}>Cancel</Text> <Text style={labelStyle}>Cancel</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
export default ChangeRolesHeaderLeftButton; export default ChangeRolesHeaderLeftButton;
View Options

keyserver/src/creators/account-creator.js

// @flow // @flow
import { HeaderBackButton as BaseHeaderBackButton } from '@react-navigation/elements'; import { HeaderBackButton as BaseHeaderBackButton } from '@react-navigation/elements';
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { Text } from 'react-native'; import { Alert, Text } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import type { NavigationRoute } from '../navigation/route-names';
import { useColors } from '../themes/colors.js'; import { useColors } from '../themes/colors.js';
type Props = React.ElementConfig<typeof BaseHeaderBackButton>; type ChangeRolesHeaderLeftButtonProps = {
function ChangeRolesHeaderLeftButton(props: Props): React.Node { +route: NavigationRoute<'ChangeRolesScreen'>,
...React.ElementConfig<typeof BaseHeaderBackButton>,
};
function ChangeRolesHeaderLeftButton(
props: ChangeRolesHeaderLeftButtonProps,
): React.Node {
const { memberInfo, role: selectedRole } = props.route.params;
const { role: memberRole } = memberInfo;
const onCancel = React.useCallback(() => {
const { onPress } = props;
invariant(onPress, 'onPress must be defined');
if (selectedRole === memberRole) {
onPress();
return;
}
Alert.alert(
'Unsaved Changes',
'You have unsaved changes, are you sure you want to cancel? You will lose all your progress',
[
{ text: 'Cancel', onPress },
{ text: 'Stay', style: 'cancel' },
],
{ cancelable: true },
);
}, [memberRole, props, selectedRole]);
rohanAuthorUnsubmitted
Done
Inline Actions

I think the wording here may be a bit confusing. In my experience, 'cancel' typically means close the alert, and there's another option like 'confirm' or something that will mean you're ok with discarding changes.

Here it seems like 'cancel' means we're ok with discarding changes. Not sure if it's just me though (cc @ted)

rohan: I think the wording here may be a bit confusing. In my experience, 'cancel' typically means…
ashoatUnsubmitted
Not Done
Inline Actions

What do we do in the current edit-message workflow? Heads-up I generally handle copy, not @ted

ashoat: What do we do in the current edit-message workflow? Heads-up I generally handle copy, not @ted
rohanAuthorUnsubmitted
Done
Inline Actions

Ah my bad. It looks like in message editing: Continue editing closes the alert and continues editing while Discard edit closes the alert and exits editing

rohan: Ah my bad. It looks like in message editing: `Continue editing` closes the alert and continues…
ashoatUnsubmitted
Not Done
Inline Actions
  1. I agree we shouldn't use the term Cancel here... how about Leave?
  2. I don't think we need { cancelable: true }... we can just default to Stay if the user dismisses the Alert
  3. Can we try to match copy for title / description with the edit-message workflow?
ashoat: 1. I agree we shouldn't use the term `Cancel` here... how about `Leave`? 2. I don't think we…
rohanAuthorUnsubmitted
Done
Inline Actions

Yeah that makes sense, I'll update the diff

rohan: Yeah that makes sense, I'll update the diff
const { panelForegroundSecondaryLabel } = useColors(); const { panelForegroundSecondaryLabel } = useColors();
const labelStyle = React.useMemo( const labelStyle = React.useMemo(
() => ({ () => ({
color: panelForegroundSecondaryLabel, color: panelForegroundSecondaryLabel,
marginLeft: 10, marginLeft: 10,
}), }),
[panelForegroundSecondaryLabel], [panelForegroundSecondaryLabel],
); );
return ( return (
<TouchableOpacity onPress={props.onPress}> <TouchableOpacity onPress={onCancel}>
<Text style={labelStyle}>Cancel</Text> <Text style={labelStyle}>Cancel</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
export default ChangeRolesHeaderLeftButton; export default ChangeRolesHeaderLeftButton;
View Options

keyserver/src/deleters/account-deleters.js

Loading...
View Options

keyserver/src/shared/message-statements.js

Loading...
View Options

lib/types/crypto-types.js

Loading...
View Options

yarn.lock

Loading...