Page MenuHomePhabricator
Differential D8323

[native] Rename holder prop to blobURI
ClosedPublic
Actions

Authored by bartek on Jun 26 2023, 9:05 PM.
Tags
None
Referenced Files
F3389489: D8323.diff
Fri, Nov 29, 7:20 PM
Unknown Object (File)
Sat, Nov 23, 2:23 PM
Unknown Object (File)
Sat, Nov 23, 7:07 AM
Unknown Object (File)
Sat, Nov 23, 7:07 AM
Unknown Object (File)
Sat, Nov 23, 7:07 AM
Unknown Object (File)
Wed, Nov 13, 1:39 AM
Unknown Object (File)
Sun, Nov 10, 7:54 PM
Unknown Object (File)
Sun, Nov 10, 12:33 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM52f0b0dcb3e8: [native] Rename holder prop to blobURI
Summary

Part of ENG-3975.
Now the holder isn't accurate, I decided to name this value blobURI because it is of format: either https://keyserver/uploads/... or blob-service://blob-hash

Depends on D8322

Test Plan

Flow, also ran the native app, cleared media cache and ensured that encrypted multimedia are still displayed as expected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jun 26 2023, 9:05 PM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptJun 26 2023, 9:05 PM
bartek added a child revision: D8324: [lib][native] Disambiguate URIs in media-cache.Jun 26 2023, 9:06 PM
Harbormaster completed remote builds in B20518: Diff 28132.Jun 26 2023, 9:29 PM
bartek published this revision for review.Jun 26 2023, 11:43 PM
bartek mentioned this in D8325: [web] Rename multimedia holder to blobURI.
bartek edited the summary of this revision. (Show Details)
bartek edited the test plan for this revision. (Show Details)
atul accepted this revision.Jun 28 2023, 12:09 PM

Looks like a pretty straightforward find and replace

This revision is now accepted and ready to land.Jun 28 2023, 12:09 PM
bartek updated this revision to Diff 28227.Jun 28 2023, 1:14 PM

Rebase

Harbormaster completed remote builds in B20590: Diff 28227.Jun 28 2023, 1:53 PM
Closed by commit rCOMM52f0b0dcb3e8: [native] Rename holder prop to blobURI (authored by bartek). · Explain WhyJun 28 2023, 11:12 PM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM52f0b0dcb3e8: [native] Rename holder prop to blobURI.
bartek mentioned this in rCOMM7b5c737769f4: [web] Rename multimedia holder to blobURI.

Revision Contents
Changeset List

Diff 28227

View Options

native/media/encrypted-image.react.js

Loading...
View Options

native/media/encryption-utils.js

Loading...
View Options

native/media/multimedia.react.js

Loading...
View Options

native/media/video-playback-modal.react.js

Loading...