Paths

Table of Contentst

Differential D8394

[web] add database module to worker
ClosedPublic
Actions

Authored by kamil on Jun 30 2023, 8:14 AM.

Tags

None

Referenced Files

	F3247302: D8394.id28415.diff
	Fri, Nov 15, 4:37 AM

	Unknown Object (File)
	Fri, Oct 18, 9:01 AM

	Unknown Object (File)
	Fri, Oct 18, 9:01 AM

	Unknown Object (File)
	Fri, Oct 18, 9:01 AM

	Unknown Object (File)
	Fri, Oct 18, 9:01 AM

	Unknown Object (File)
	Fri, Oct 18, 9:01 AM

	Unknown Object (File)
	Fri, Oct 18, 9:00 AM

	Unknown Object (File)
	Fri, Oct 18, 8:51 AM

Subscribers

Details

Reviewers

• jon
michal
tomek

Commits

rCOMMee91a70f5226: [web] add database module to worker

Summary

Adding logic to use .wasm module on web.

Test Plan

Check if result is properly logged from web in prod/dev and desktop.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 30 2023, 8:14 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 30 2023, 8:14 AM

kamil added a parent revision: D8393: [web] copy `.wasm` files using webpack.Jun 30 2023, 8:24 AM

Harbormaster failed remote builds in B20648: Diff 28302!Jun 30 2023, 8:28 AM

typo

kamil added inline comments.Jun 30 2023, 8:57 AM

web/database/worker/db-worker.js
80	types will be added in subsequent diff

kamil published this revision for review.Jun 30 2023, 8:59 AM

Harbormaster completed remote builds in B20652: Diff 28306.Jun 30 2023, 9:14 AM

ashoat added inline comments.Jul 3 2023, 8:17 AM

keyserver/src/responders/website-responders.js
97 ↗	(On Diff #28306)	The other properties have `Filename` as one word. Would be good to maintain consistency

ashoat added inline comments.Jul 3 2023, 10:19 AM

keyserver/src/responders/website-responders.js
138 ↗	(On Diff #28306)	Can we try to match the convention of `comm_opaque2_wasm_bg.wasm`? So I guess it would be `comm_query_executor.wasm`
web/database/worker/db-worker.js
69 ↗	(On Diff #28306)	Is this `console.log` accidentally left over from testing? If not, and you want to keep it, we should probably add some additional context to the message

Looks ok, but please address the comments.

This revision is now accepted and ready to land.Jul 5 2023, 2:17 AM

kamil mentioned this in D8390: [shell] script to generate WASM database code.Jul 5 2023, 6:41 AM

improve naming convention

keyserver/src/responders/website-responders.js
97 ↗	(On Diff #28306)	done!
138 ↗	(On Diff #28306)	We have two options: Generate files named `comm_query_executor.`, but then in JS we will have to include `import Module from '../_generated/comm_query_executor.js';` which doesn't really match including convention. Generate files named `comm-query-executor.` and rename `.wasm` file to `comm_query_executor.wasm`, but we will have to hardcode the default filename from `locateFile()` callback because it has `comm-query-executor.wasm` set as default. I implemented option 2.
web/database/worker/db-worker.js
69 ↗	(On Diff #28306)	left over, should've never been committed, removing

Harbormaster completed remote builds in B20742: Diff 28415.Jul 5 2023, 7:34 AM

ashoat added inline comments.Jul 5 2023, 10:36 AM

keyserver/src/responders/website-responders.js
138 ↗	(On Diff #28306)	Makes sense!

rebase

Harbormaster completed remote builds in B20897: Diff 28619.Jul 12 2023, 5:48 AM

Closed by commit rCOMMee91a70f5226: [web] add database module to worker (authored by kamil). · Explain WhyJul 12 2023, 6:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMee91a70f5226: [web] add database module to worker.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

website-responders.js

15 lines

web/

database/

database-module-provider.js

2 lines

worker/

20 lines

types/

worker-types.js

1 line

Diff 28302

keyserver/src/responders/website-responders.js

Loading...

web/database/database-module-provider.js

Loading...

web/database/worker/db-worker.js

Loading...

web/types/worker-types.js

Loading...