Page MenuHomePhabricator
Differential D8389

[web] implement test c++ class
ClosedPublic
Actions

Authored by kamil on Jun 30 2023, 7:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 18, 9:00 AM
Unknown Object (File)
Fri, Oct 18, 9:00 AM
Unknown Object (File)
Fri, Oct 18, 9:00 AM
Unknown Object (File)
Fri, Oct 18, 9:00 AM
Unknown Object (File)
Fri, Oct 18, 9:00 AM
Unknown Object (File)
Fri, Oct 18, 8:51 AM
Unknown Object (File)
Oct 5 2024, 10:44 AM
Unknown Object (File)
Oct 5 2024, 10:42 AM
View All Files
Subscribers
ashoat

Details

Reviewers
• jon
tomek
michal
Commits
rCOMM097020a6acb4: [web] implement test c++ class
Summary

This class will be removed, adding this here to iterate over compiling code to WASM and share a general idea.
I will start adding proper implementation after some changes to the native code.

Depends on D8375

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jun 30 2023, 7:26 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJun 30 2023, 7:26 AM
kamil updated this revision to Diff 28292.Jun 30 2023, 7:28 AM

typo

Harbormaster completed remote builds in B20639: Diff 28291.Jun 30 2023, 7:43 AM
Harbormaster completed remote builds in B20640: Diff 28292.
kamil added a child revision: D8390: [shell] script to generate WASM database code.Jun 30 2023, 8:22 AM
kamil added inline comments.Jun 30 2023, 8:36 AM
native/cpp/CommonCpp/DatabaseManagers/CommQueryExecutor.cpp
57 ↗(On Diff #28292)

looks dummy but the reason is to check if we can use both sqlite3 and sqlite_orm API

kamil published this revision for review.Jun 30 2023, 8:36 AM
tomek accepted this revision.Jul 5 2023, 1:38 AM
tomek added inline comments.
native/cpp/CommonCpp/DatabaseManagers/CommQueryExecutor.cpp
58 ↗(On Diff #28292)

Should we drop the table at the end?

This revision is now accepted and ready to land.Jul 5 2023, 1:38 AM
kamil updated this revision to Diff 28411.Jul 5 2023, 6:36 AM

remove file

native/cpp/CommonCpp/DatabaseManagers/CommQueryExecutor.cpp
58 ↗(On Diff #28292)

actually, I will delete the entire file to save space in virtual memory

Harbormaster completed remote builds in B20738: Diff 28411.Jul 5 2023, 6:55 AM
Closed by commit rCOMM097020a6acb4: [web] implement test c++ class (authored by kamil). · Explain WhyJul 12 2023, 6:04 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM097020a6acb4: [web] implement test c++ class.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
2 lines
11 lines
75 lines
ios/
Comm.xcodeproj/
6 lines

Diff 28411

View Options

native/cpp/CommonCpp/DatabaseManagers/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/CommQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/CommQueryExecutor.cpp

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...