Page MenuHomePhabricator

[lib] Add hasMinStateVersion
ClosedPublic

Authored by michal on Jul 10 2023, 10:25 AM.
Tags
None
Referenced Files
F3492036: D8466.id28557.diff
Wed, Dec 18, 9:51 PM
F3491417: D8466.diff
Wed, Dec 18, 7:13 PM
Unknown Object (File)
Sun, Dec 15, 10:37 PM
Unknown Object (File)
Sun, Dec 15, 10:37 PM
Unknown Object (File)
Sun, Dec 15, 10:37 PM
Unknown Object (File)
Sun, Dec 15, 10:22 PM
Unknown Object (File)
Fri, Dec 13, 7:25 PM
Unknown Object (File)
Mon, Nov 25, 2:56 PM
Subscribers

Details

Summary

ENG-4350

Added so landing the id schema migration stack doesn't break dev env. Wasn't sure if it should be merged with hasMinCodeVersion but I can't imagine a scenario where we want to check both code version and state version, and it would complicate the logic a bit so I decided against it. But I'm open to changes.

Test Plan

Tested with the next diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil added inline comments.
lib/shared/version-utils.js
39–59

wondering if there is an easy way to create a generic function and put shared logic there as hasMinCodeVersion, but probably this will make the code more complicated and less readable, so this also looks okay

This revision is now accepted and ready to land.Jul 11 2023, 2:10 AM
lib/shared/version-utils.js
39–59

I tried to generalise the code but it always made the logic more complicated so I don't think it's worth it.