[keyserver] Remove target blank
ClosedPublic
Actions

Authored by tomek on Jul 12 2023, 2:34 AM.

Tags

None

Referenced Files

	F3203680: D8486.id28652.diff
	Sat, Nov 9, 8:11 PM

	F3195823: D8486.id.diff
	Sat, Nov 9, 4:04 AM

	Unknown Object (File)
	Fri, Nov 8, 8:03 AM

	Unknown Object (File)
	Fri, Nov 8, 8:03 AM

	Unknown Object (File)
	Oct 3 2024, 2:07 AM

	Unknown Object (File)
	Sep 24 2024, 4:21 AM

	Unknown Object (File)
	Sep 23 2024, 12:48 AM

	Unknown Object (File)
	Sep 19 2024, 4:27 PM

View All 63 Files

Subscribers

ashoat

Details

Reviewers

kamil
inka

Commits

rCOMM041958e44a76: [keyserver] Remove target blank

Summary

Unfortunately, it doesn't solve https://linear.app/comm/issue/ENG-4089/invite-links-dont-work-on-prod.

Test Plan

Check if clicking a link in Chrome doesn't open a new card.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jul 12 2023, 2:34 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 12 2023, 2:34 AM

Harbormaster completed remote builds in B20893: Diff 28615.Jul 12 2023, 2:52 AM

tomek requested review of this revision.Jul 12 2023, 2:52 AM

Personally, I would revert D8465 instead of doing it manually but this also looks okay

This revision is now accepted and ready to land.Jul 12 2023, 7:35 AM

ahh nvm, I see the difference - ignore my comment

Closed by commit rCOMM041958e44a76: [keyserver] Remove target blank (authored by tomek). · Explain WhyJul 13 2023, 2:03 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM041958e44a76: [keyserver] Remove target blank.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

website-responders.js

6 lines

Diff 28652

View Options

keyserver/src/responders/website-responders.js

[keyserver] Remove target blankClosedPublicActions