https://linear.app/comm/issue/ENG-3995/create-functions-for-migrating-the-client-stores
This diff introduces functions for migrating the draft store, both in cases when it is persisted in redux and when it's stored in sqlite
Depends on D8355
Details
Details
- Reviewers
kamil tomek - Commits
- rCOMMadd674080815: [lib] Add conversions for draft store
Run yarn test, tested with the next diffs if they correctly migrated the draft stores
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/utils/migration-utils.js | ||
|---|---|---|
| 15 ↗ | (On Diff #28283) | I would define message_composer as separate constant in lib and update draftKeyFromThreadID() to use it |
| 23 ↗ | (On Diff #28283) | can be simplified |
| 26–33 ↗ | (On Diff #28283) | I think an early exit will make this more readable |
| 47–58 ↗ | (On Diff #28283) | There is an alternative approach based on MOVE_DRAFT, this will require some changes in this logic and seems more suitable, but removing everything and creating new entries is a frequent pattern in codebase so probably it's okay as it is |
Comment Actions
Address review.
Left the draft ops logic the same. We use the remove and create new for everything else in this migration so it should be fine.