Page MenuHomePhabricator
Differential D8534

[lib, web, native] Use KesyerverStore to get current cookie
ClosedPublic
Actions

Authored by inka on Jul 18 2023, 12:45 PM.
Tags
None
Referenced Files
F3529634: D8534.id28786.diff
Tue, Dec 24, 8:30 PM
F3528181: D8534.diff
Tue, Dec 24, 8:32 AM
Unknown Object (File)
Sat, Dec 7, 2:58 PM
Unknown Object (File)
Nov 23 2024, 7:17 AM
Unknown Object (File)
Nov 10 2024, 10:54 PM
Unknown Object (File)
Nov 10 2024, 10:54 PM
Unknown Object (File)
Nov 10 2024, 10:54 PM
Unknown Object (File)
Nov 9 2024, 9:42 AM
View All 77 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
Commits
rCOMMb8bae5a66f89: [lib, web, native] Use KesyerverStore to get current cookie
Summary

https://linear.app/comm/issue/ENG-4377/refactor-cookie-field-in-web-redux
Start using the cookie field from keyserverStore, in places where state.cookie was being fetched

In this first iteration we are hardcoding the id of our keyserver

Test Plan

ran yarn flow-all. Chekced with git grep that in all places the cookie from state was being used, the state.keyserverStore.keyserverInfos[].cookie is used instead (went through all occurences of 'cookie')

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Jul 18 2023, 12:45 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 18 2023, 12:45 PM
inka added inline comments.Jul 18 2023, 12:47 PM
lib/selectors/keyserver-selectors.js
8 ↗(On Diff #28786)

This is a hack that allows to use this selector before cookie is removed from state and migration from cookie to keyserverStore.keyserverInfos[].cookie is done. This is only done to keep the diffs small

inka added a child revision: D8535: [lib] Create generic cookies selector.Jul 18 2023, 12:50 PM
inka added a parent revision: D8532: [lib, native,keyserver] Add KeyserverStore.Jul 18 2023, 1:04 PM
Harbormaster completed remote builds in B20996: Diff 28786.Jul 18 2023, 1:04 PM
inka requested review of this revision.Jul 18 2023, 1:04 PM
michal accepted this revision.Jul 19 2023, 6:10 AM
This revision is now accepted and ready to land.Jul 19 2023, 6:10 AM
inka updated this revision to Diff 28851.Jul 19 2023, 9:52 AM

change keyserverPrefixID to ashoatKeyserverID

Harbormaster completed remote builds in B21055: Diff 28851.Jul 19 2023, 10:29 AM
Closed by commit rCOMMb8bae5a66f89: [lib, web, native] Use KesyerverStore to get current cookie (authored by inka). · Explain WhyJul 21 2023, 1:55 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMb8bae5a66f89: [lib, web, native] Use KesyerverStore to get current cookie.

Revision Contents
Changeset List

PathSize
lib/
selectors/
3 lines
10 lines
3 lines
shared/
3 lines
native/
account/
3 lines
data/
3 lines
navigation/
8 lines
selectors/
5 lines
3 lines
web/
3 lines

Diff 28923

View Options

lib/selectors/account-selectors.js

Loading...
View Options

lib/selectors/keyserver-selectors.js

Loading...
View Options

lib/selectors/server-calls.js

Loading...
View Options

lib/shared/session-utils.js

Loading...
View Options

native/account/logged-out-modal.react.js

Loading...
View Options

native/data/sqlite-data-handler.js

Loading...
View Options

native/navigation/navigation-handler.react.js

Loading...
View Options

native/selectors/socket-selectors.js

Loading...
View Options

native/socket.react.js

Loading...
View Options

web/socket.react.js

Loading...